You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Matt Juntunen <ma...@hotmail.com> on 2020/04/03 15:25:10 UTC
[VOTE] Release Apache Commons Numbers (full distribution) 1.0-beta1
based on RC1
We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
These are the artifacts and their hashes:
#Release SHA-512s
#Fri Apr 03 08:03:05 EDT 2020
commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I have tested this with ***'mvn clean install site'*** using:
***
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 1.8.0_242, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
***
Details of changes are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
(note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
CLIRR Report:
N/A
JApiCmp Report:
N/A
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Matt Juntunen,
Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
cd commons-numbers-1.0-beta1-rc1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you then must check.
mvn apache-rat:check
3) Check binary compatibility
Older components still use Apache Clirr:
This step is not required if the site includes a Clirr report page which you then must check.
mvn clirr:check
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Matt Juntunen <ma...@hotmail.com>.
I didn't realize that the dist/dev site was missing the modules. I've also deployed the fully staged version to https://home.apache.org/~mattjuntunen/commons-numbers-1.0-beta1-rc1-site/ so you can review it from there.
-Matt
________________________________
From: Gilles Sadowski <gi...@gmail.com>
Sent: Friday, April 3, 2020 5:45 PM
To: Commons Developers List <de...@commons.apache.org>
Subject: Re: [VOTE] Release Apache Commons Numbers (full distribution) 1.0-beta1 based on RC1
Hi.
Le ven. 3 avr. 2020 à 17:25, Matt Juntunen <ma...@hotmail.com> a écrit :
>
> We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
>
> Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
>
> The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
> https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
Checked with
$ git tag -v commons-numbers-1.0-beta1-rc1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Apr 03 08:03:05 EDT 2020
>
>
> commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
> commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
> commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
> commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I've opened
https://issues.apache.org/jira/projects/COMMONSSITE/issues/COMMONSSITE-133
>
> I have tested this with ***'mvn clean install site'*** using:
> ***
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
> Maven home: /home/matt/tools/maven/apache-maven-3.5.3
> Java version: 1.8.0_242, vendor: Private Build
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
> ***
Builds fine with Java8, 9 and 11 (on Linux).
>
> Details of changes are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
>
> Site:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
> (note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
All the modules
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/modules.html
are missing.
>
> CLIRR Report:
> N/A
>
> JApiCmp Report:
> N/A
>
> RAT Report:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
This only points to one of the reports in a multi-module component.
I've opened this:
https://issues.apache.org/jira/browse/COMMONSSITE-134
Checked with
$ grep 'Unknown License' */target/rat.txt
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
[X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Matt Juntunen,
> Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
> cd commons-numbers-1.0-beta1-rc1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
For a multi-module component, the site is in
target/staging
under the top-level directory.
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Gilles Sadowski <gi...@gmail.com>.
Hi.
Le ven. 3 avr. 2020 à 17:25, Matt Juntunen <ma...@hotmail.com> a écrit :
>
> We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
>
> Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
>
> The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
> https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
Checked with
$ git tag -v commons-numbers-1.0-beta1-rc1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
>
> Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Fri Apr 03 08:03:05 EDT 2020
>
>
> commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
> commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
> commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
> commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I've opened
https://issues.apache.org/jira/projects/COMMONSSITE/issues/COMMONSSITE-133
>
> I have tested this with ***'mvn clean install site'*** using:
> ***
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
> Maven home: /home/matt/tools/maven/apache-maven-3.5.3
> Java version: 1.8.0_242, vendor: Private Build
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
> ***
Builds fine with Java8, 9 and 11 (on Linux).
>
> Details of changes are in the release notes:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
>
> Site:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
> (note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
All the modules
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/modules.html
are missing.
>
> CLIRR Report:
> N/A
>
> JApiCmp Report:
> N/A
>
> RAT Report:
> https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
This only points to one of the reports in a multi-module component.
I've opened this:
https://issues.apache.org/jira/browse/COMMONSSITE-134
Checked with
$ grep 'Unknown License' */target/rat.txt
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
[X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Matt Juntunen,
> Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
> cd commons-numbers-1.0-beta1-rc1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean package
>
> You can record the Maven and Java version produced by -V in your VOTE reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a single module project
>
> Note: Some plugins require the components to be installed instead of packaged.
>
> mvn site
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> 6) Build the site for a multi-module project
>
> mvn site
> mvn site:stage
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
For a multi-module component, the site is in
target/staging
under the top-level directory.
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[VOTE][RESULT] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Matt Juntunen <ma...@hotmail.com>.
This VOTE passes with the following +1 binding votes:
* Gilles Sadowski
* Bruno Kinoshita
* Alex Herbert
I will proceed with the release and send the announcement 24 hours after it is complete.
Thank you all,
Matt J
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le sam. 4 avr. 2020 à 17:13, Alex Herbert <al...@gmail.com> a écrit :
>
>
> > On 4 Apr 2020, at 01:49, Bruno P. Kinoshita <ki...@apache.org> wrote:
> >
> > Build passed locally from tag, with `mvn clean test install site` after 21mins
>
> Hi Bruno,
>
> This is a known issue with the multi-module build when the ‘site-content’ directory is missing and you run the ‘site’ target as it downloads the existing site. It does this for each module. The more modules, the bigger the problem.
IMO it is a misfeature, independent of whether the component is
multi-module or not.
What's the purpose of checking out the (live) site into "site-content"
when the build is creating the new site in "target/site" (or "target/staging")?
It is a fact that we never vote on the contents of the web site, not even
for a release vote (since in that case, many links are broken).
So, IMHO, the vote for a release should skip any site check, and when
the release it is a convienience (as it is now) that the site is maintained
up-to-date (by anyone, not necessarily the RM).
Then, populating the directory "site-content" (by deleting the old content
and copying from the build run within the release branch) is a separate
and well defined task (done *after* the release, avoiding the "dangling
links" issue).
> The site-content folder is just a convenience when staging a new site during a release.
Inconvenience, you mean. ;-)
> Perhaps this entire process should be rethought as the directory serves no other purpose that I know of.
+1 (as mentioned above).
>
> This has been fixed in commons RNG using a custom setup-checkout profile. Either we:
>
> 1. copy the solution in commons RNG which does the checkout only for the parent module and creates a dummy directory for child modules, or
> 2. change the profile to not automatically trigger when ’site-content’ is missing. The profile can be optional and used only in the release process when staging the site.
I think that "site-content" should be left alone by the build.
Moreover I think that it's a bad idea to have a directory managed
by "svn" under a directoy managed by "git".
When someone wants to update a component's web site, he
could just "svn co" into a separate area of the filesystem.
>
> Note that the site generates automatically without this folder. If you create an empty folder 'site-content' and run 'mvn site' then it all works fine.
That's *the* workaround, but it's easy to forget and then use a lot
of bandwidth for nothing... :-}
>
> A clean checkout from the tag:
>
> mvn package site
>
> 12:58 min
>
>
> Clean check from the tag:
>
> mkdir ./commons-numbers-arrays/site-content
> mkdir ./commons-numbers-field/site-content
> mkdir ./commons-numbers-gamma/site-content
> mkdir ./commons-numbers-fraction/site-content
> mkdir ./commons-numbers-core/site-content
> mkdir ./commons-numbers-angle/site-content
> mkdir ./commons-numbers-primes/site-content
> mkdir ./commons-numbers-combinatorics/site-content
> mkdir ./commons-numbers-rootfinder/site-content
> mkdir ./site-content
> mkdir ./commons-numbers-complex/site-content
> mkdir ./commons-numbers-quaternion/site-content
> mvn package site
>
> 3:46 min
>
> So disabling the profile to checkout the site would save 2/3 of the build time from a clean checkout. Note: Currently a repeat build in the same git clone is fast as the site-content directory already already exists.
>
> The multi-module build also takes a while generating the site as the Jira report is built for each module and this is the slowest report. We have three options here.
>
> 1. Build the full Jira report in each sub-module
> 2. Disable the Jira report in each sub-module
> 3. Build a partial Jira report in each sub-module
>
> In RNG we use option 3. The partial report is built using keyword tags on the Jira tickets to identify to a module. The report then only contains items that relate to the module. This is useful but the site generation takes the same amount of time because generation of a full Jira report or partial report takes the same time. It also requires diligent keyword tagging of tickets.
As long as the release notes contain a collated list of all
the components' issues (so that users can quickly figure
out if they would be impacted by upgrading, and whatever
new features are available), I think that it's the cleanest option.
Best regards,
Gilles
>
> Alex
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Alex Herbert <al...@gmail.com>.
Builds fine from the git tag with JDK.8 and 11 on MacOS:
mvn -v
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 1.8.0_131, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.4", arch: "x86_64", family: "mac"
mvn -v
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 11.0.5, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.4", arch: "x86_64", family: "mac"
Does not build with JDK 14. This is due to a dependency on a version of Groovy that is not supported in Java 14 that is brought in by spotbugs 3.1.8. We should try updating to spot bugs 4.0.0.
Also builds fine from the downloaded tarball.
+1 - Release these artifacts
Alex
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Alex Herbert <al...@gmail.com>.
> On 4 Apr 2020, at 01:49, Bruno P. Kinoshita <ki...@apache.org> wrote:
>
> Build passed locally from tag, with `mvn clean test install site` after 21mins
Hi Bruno,
This is a known issue with the multi-module build when the ‘site-content’ directory is missing and you run the ‘site’ target as it downloads the existing site. It does this for each module. The more modules, the bigger the problem.
The site-content folder is just a convenience when staging a new site during a release. Perhaps this entire process should be rethought as the directory serves no other purpose that I know of.
This has been fixed in commons RNG using a custom setup-checkout profile. Either we:
1. copy the solution in commons RNG which does the checkout only for the parent module and creates a dummy directory for child modules, or
2. change the profile to not automatically trigger when ’site-content’ is missing. The profile can be optional and used only in the release process when staging the site.
Note that the site generates automatically without this folder. If you create an empty folder 'site-content' and run 'mvn site' then it all works fine.
A clean checkout from the tag:
mvn package site
12:58 min
Clean check from the tag:
mkdir ./commons-numbers-arrays/site-content
mkdir ./commons-numbers-field/site-content
mkdir ./commons-numbers-gamma/site-content
mkdir ./commons-numbers-fraction/site-content
mkdir ./commons-numbers-core/site-content
mkdir ./commons-numbers-angle/site-content
mkdir ./commons-numbers-primes/site-content
mkdir ./commons-numbers-combinatorics/site-content
mkdir ./commons-numbers-rootfinder/site-content
mkdir ./site-content
mkdir ./commons-numbers-complex/site-content
mkdir ./commons-numbers-quaternion/site-content
mvn package site
3:46 min
So disabling the profile to checkout the site would save 2/3 of the build time from a clean checkout. Note: Currently a repeat build in the same git clone is fast as the site-content directory already already exists.
The multi-module build also takes a while generating the site as the Jira report is built for each module and this is the slowest report. We have three options here.
1. Build the full Jira report in each sub-module
2. Disable the Jira report in each sub-module
3. Build a partial Jira report in each sub-module
In RNG we use option 3. The partial report is built using keyword tags on the Jira tickets to identify to a module. The report then only contains items that relate to the module. This is useful but the site generation takes the same amount of time because generation of a full Jira report or partial report takes the same time. It also requires diligent keyword tagging of tickets.
Alex
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
Had a quick look at some of the files in the Maven repository, and found no issues.
Checked signatures and found nothing out of ordinary.
[x] +1 Release these artifacts
Thanks!
Bruno
On Saturday, 4 April 2020, 2:19:04 pm NZDT, Matt Juntunen <ma...@hotmail.com> wrote:
> @Matt, is the Maven repository link working for you?
It is not. I'm not sure what's going on with that. I can log into Nexus and view the artifacts under staging repo 1497, though. I can also browse the contents if I go to https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/. Perhaps this is an issue with single module vs multi-module projects?
-Matt
________________________________
From: Bruno P. Kinoshita <ki...@apache.org>
Sent: Friday, April 3, 2020 8:49 PM
To: Commons Developers List <de...@commons.apache.org>
Subject: Re: [VOTE] Release Apache Commons Numbers (full distribution) 1.0-beta1 based on RC1
Build passed locally from tag, with `mvn clean test install site` after 21mins
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_242, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
In the changelog (report & RELEASE-NOTES.txt) I could see the warning about it being a beta release, great.
The code coverage is really good, well done. Found no RAT issues. Other reports look good too.
LICENSE, NOTICE, RELEASE-NOTES look OK too in the archives in the dist area. No issues with files signatures.
@Matt, is the Maven repository link working for you?
>Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
Cheers
Bruno
On Saturday, 4 April 2020, 4:25:26 am NZDT, Matt Juntunen <ma...@hotmail.com> wrote:
We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
These are the artifacts and their hashes:
#Release SHA-512s
#Fri Apr 03 08:03:05 EDT 2020
commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I have tested this with ***'mvn clean install site'*** using:
***
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 1.8.0_242, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
***
Details of changes are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
(note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
CLIRR Report:
N/A
JApiCmp Report:
N/A
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Matt Juntunen,
Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
cd commons-numbers-1.0-beta1-rc1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you then must check.
mvn apache-rat:check
3) Check binary compatibility
Older components still use Apache Clirr:
This step is not required if the site includes a Clirr report page which you then must check.
mvn clirr:check
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by Matt Juntunen <ma...@hotmail.com>.
> @Matt, is the Maven repository link working for you?
It is not. I'm not sure what's going on with that. I can log into Nexus and view the artifacts under staging repo 1497, though. I can also browse the contents if I go to https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/. Perhaps this is an issue with single module vs multi-module projects?
-Matt
________________________________
From: Bruno P. Kinoshita <ki...@apache.org>
Sent: Friday, April 3, 2020 8:49 PM
To: Commons Developers List <de...@commons.apache.org>
Subject: Re: [VOTE] Release Apache Commons Numbers (full distribution) 1.0-beta1 based on RC1
Build passed locally from tag, with `mvn clean test install site` after 21mins
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_242, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
In the changelog (report & RELEASE-NOTES.txt) I could see the warning about it being a beta release, great.
The code coverage is really good, well done. Found no RAT issues. Other reports look good too.
LICENSE, NOTICE, RELEASE-NOTES look OK too in the archives in the dist area. No issues with files signatures.
@Matt, is the Maven repository link working for you?
>Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
Cheers
Bruno
On Saturday, 4 April 2020, 4:25:26 am NZDT, Matt Juntunen <ma...@hotmail.com> wrote:
We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
These are the artifacts and their hashes:
#Release SHA-512s
#Fri Apr 03 08:03:05 EDT 2020
commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I have tested this with ***'mvn clean install site'*** using:
***
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 1.8.0_242, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
***
Details of changes are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
(note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
CLIRR Report:
N/A
JApiCmp Report:
N/A
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Matt Juntunen,
Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
cd commons-numbers-1.0-beta1-rc1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you then must check.
mvn apache-rat:check
3) Check binary compatibility
Older components still use Apache Clirr:
This step is not required if the site includes a Clirr report page which you then must check.
mvn clirr:check
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
Re: [VOTE] Release Apache Commons Numbers (full distribution)
1.0-beta1 based on RC1
Posted by "Bruno P. Kinoshita" <ki...@apache.org>.
Build passed locally from tag, with `mvn clean test install site` after 21mins
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_242, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_NZ, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
In the changelog (report & RELEASE-NOTES.txt) I could see the warning about it being a beta release, great.
The code coverage is really good, well done. Found no RAT issues. Other reports look good too.
LICENSE, NOTICE, RELEASE-NOTES look OK too in the archives in the dist area. No issues with files signatures.
@Matt, is the Maven repository link working for you?
>Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
Cheers
Bruno
On Saturday, 4 April 2020, 4:25:26 am NZDT, Matt Juntunen <ma...@hotmail.com> wrote:
We have been working hard to prepare Apache Commons Numbers for an initial release, so I would like to release Apache Commons Numbers (full distribution) 1.0-beta1.
Apache Commons Numbers (full distribution) 1.0-beta1 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1 (svn revision 38800)
The Git tag commons-numbers-1.0-beta1-rc1 commit for this RC is 3406c0980b4bc1071314bbb081dad2ef49cd68d3 which you can browse here:
https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=commit;h=3406c0980b4bc1071314bbb081dad2ef49cd68d3
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1497/org/apache/commons/commons-numbers/1.0-beta1/
These are the artifacts and their hashes:
#Release SHA-512s
#Fri Apr 03 08:03:05 EDT 2020
commons-numbers-1.0-beta1-bin.tar.gz=0a18312d62e53937ac82e17c971db028054da45d9ee3937aec80f296ab73fa49f5dc42c9e381ae9693240284993e4426e70a27b412c409c1c5f1b2f3ad78b551
commons-numbers-1.0-beta1-bin.zip=36ffbb850f0f6a51dd96236ddf27566e82ab6b68344ee9ff29a680e78ebdd4e136675856576f03ca4af63362fd115282e2b2289715db4587933a00b7d0a58f62
commons-numbers-1.0-beta1-src.tar.gz=963dd030406a35d7abf180e87ea0d07e4d663da222403ac9cab13ed2d64076422a924fb3e3732c0168de8224396737df87aaeb06971dab9582e599a0edd8ba1c
commons-numbers-1.0-beta1-src.zip=db931f1b9c7383ffeb87db2dc8629fc19f2044ff6b2e4a96d1284512106d59db81428eed7cbdd1e5e99dfebc3d68738dc87197bf67659d53d1b7c8db3545478c
I have tested this with ***'mvn clean install site'*** using:
***
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T14:49:05-05:00)
Maven home: /home/matt/tools/maven/apache-maven-3.5.3
Java version: 1.8.0_242, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-91-generic", arch: "amd64", family: "unix"
***
Details of changes are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/RELEASE-NOTES.txt
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/changes-report.html
Site:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/index.html
(note some *relative* links are broken and the 1.0-beta1 directories are not yet created - these will be OK once the site is deployed.)
CLIRR Report:
N/A
JApiCmp Report:
N/A
RAT Report:
https://dist.apache.org/repos/dist/dev/commons/numbers/1.0-beta1-RC1/site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner that 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Matt Juntunen,
Release Manager (using key 7DD53AEFEDF1C3D392B51EBE346F4FCECFB70B1A)
For following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-numbers.git --branch commons-numbers-1.0-beta1-rc1 commons-numbers-1.0-beta1-rc1
cd commons-numbers-1.0-beta1-rc1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you then must check.
mvn apache-rat:check
3) Check binary compatibility
Older components still use Apache Clirr:
This step is not required if the site includes a Clirr report page which you then must check.
mvn clirr:check
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean package
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a single module project
Note: Some plugins require the components to be installed instead of packaged.
mvn site
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
6) Build the site for a multi-module project
mvn site
mvn site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html