[GitHub] [arrow] wgtmac commented on a diff in pull request #33995: MINOR: [C++][Parquet] Parquet: Some tiny updates on bf

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #33995:
URL: https://github.com/apache/arrow/pull/33995#discussion_r1094043826


##########
cpp/src/parquet/bloom_filter.h:
##########
@@ -36,7 +36,7 @@ class PARQUET_EXPORT BloomFilter {
  public:
   // Maximum Bloom filter size, it sets to HDFS default block size 128MB
   // This value will be reconsidered when implementing Bloom filter producer.
-  static constexpr uint32_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;
+  static constexpr uint64_t kMaximumBloomFilterBytes = 128 * 1024 * 1024;

Review Comment:
   Should the return type of `OptimalNumOfBits` be changed to uint64_t as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org