You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apex.apache.org by chinmaykolhatkar <gi...@git.apache.org> on 2016/04/12 08:46:32 UTC

[GitHub] incubator-apex-core pull request: APEXCORE-340 Naming change of ap...

GitHub user chinmaykolhatkar opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/303

    APEXCORE-340 Naming change of apex script.

    Changed following (dt->apex):
    1. Script name changed to apex.
    2. Class name changed to ApexCli from DTCli. Similar for test class.
    3. Changed console prompt to "apex>" from "dt>"
    4. Changed Welcome message to "Apex CLI ..." from "DT CLI ..."
    
    @davidyan74 Please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chinmaykolhatkar/incubator-apex-core APEXCORE-340

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #303
    
----
commit 0d8d45dfa817a8b79bf204e34656db6a35c0955d
Author: chinmaykolhatkar <ch...@datatorrent.com>
Date:   2016-04-11T10:26:42Z

    APEXCORE-340 Naming change of apex script.
    Changed following (dt->apex):
    1. Script name changed to apex.
    2. Class name changed to ApexCli from DTCli. Similar for test class.
    3. Changed console prompt to "apex>" from "dt>"
    4. Changed Welcome message to "Apex CLI ..." from "DT CLI ..."

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-340 Naming change of ap...

Posted by davidyan74 <gi...@git.apache.org>.

Github user davidyan74 commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/303#issuecomment-209087975
  
    @chinmaykolhatkar The PR looks good to me. I'll let this sit around for a couple days so that other people can chime in before I merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-340 Naming change of ap...

Posted by tweise <gi...@git.apache.org>.

Github user tweise commented on the pull request:

    https://github.com/apache/incubator-apex-core/pull/303#issuecomment-209099592
  
    docs/images/security/image02_apex.png
    
    Why are we not replacing the existing image? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-apex-core pull request: APEXCORE-340 Naming change of ap...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-apex-core/pull/303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---