[jira] Commented: (THRIFT-916) gcc warnings in c++ header files

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928327#action_12928327 ] 

Roger Meier commented on THRIFT-916:
------------------------------------

just verified your patch Christian => +1

what about the unused parameters within the code? set them to a default value?

> gcc warnings in c++ header files
> --------------------------------
>
>                 Key: THRIFT-916
>                 URL: https://issues.apache.org/jira/browse/THRIFT-916
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.4
>            Reporter: Piotr Bartosiewicz
>            Assignee: Roger Meier
>         Attachments: make-k.log, THRIFT-916_Wall_pedantic__noerrors.patch, v1-fix-format-strings.patch, v1-fix-java-style-and-warnings.patch, v1-fix-random-silly-warnings.patch, v2-fix-all-warnings.patch, v3-fix-all-warnings.patch, v4-fix-all-warnings.patch
>
>
> I tried to add an extra gcc warning options in my project but a number of warnings was emmited from thrift headers.
> Following the boost library recommendations, code should be clean with "-Wall -Wextra -pedantic" options. 
> Currently only with -Wall thrift has no warnings. 
> Other options worth considering (but require more work) are -Wconversion -Wold-style-cast
> So the task is to improve the thrift headers. 
> I suggest also update all the thrift makefiles so the thrift sources an tests will indicate the faulty code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.