[GitHub] [hive] b-slim commented on a change in pull request #665: HIVE-21832: New metrics to get the average queue/serving/response time

[GitBox <gi...@apache.org>]

b-slim commented on a change in pull request #665: HIVE-21832: New metrics to get the average queue/serving/response time
URL: https://github.com/apache/hive/pull/665#discussion_r291656149
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/metrics/LlapDaemonExecutorMetrics.java
 ##########
 @@ -195,14 +202,22 @@ private LlapDaemonExecutorMetrics(String displayName, JvmMetrics jm, String sess
       this.executorThreadUserTime[i] = registry.newGauge(miu, 0L);
       this.executorNames.put(ContainerRunnerImpl.THREAD_NAME_FORMAT_PREFIX + i, i);
     }
+    if (simpleAverageWindowDataSize > 0) {
+      this.queueTime = new SynchronizedDescriptiveStatistics(simpleAverageWindowDataSize);
 
 Review comment:
   took quick look at the implementation of `SynchronizedDescriptiveStatistics`  and i see synchronized everywhere,
   maybe be this is not an issue yet but i can see how it can be become an issue in the future as a source of contentions, wondering if we can use a longAdder to compute ourself the the average, that should be lock free and will probably spread the contention. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org