You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/11 12:57:59 UTC

[GitHub] Fokko commented on a change in pull request #3880: [AIRFLOW-461] Support autodetected schemas in BigQuery run_load

Fokko commented on a change in pull request #3880: [AIRFLOW-461]  Support autodetected schemas in BigQuery run_load
URL: https://github.com/apache/incubator-airflow/pull/3880#discussion_r216658198
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -851,8 +851,9 @@ def run_copy(self,
 
     def run_load(self,
                  destination_project_dataset_table,
 
 Review comment:
   This breaks backward compatibility. This is ok if we target it to Airflow 2.0, and add a line to `CONTRIBUTING.md`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services