You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "laurentschoelens (via GitHub)" <gi...@apache.org> on 2023/04/03 07:27:39 UTC
[GitHub] [commons-lang] laurentschoelens opened a new pull request, #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
laurentschoelens opened a new pull request, #1047:
URL: https://github.com/apache/commons-lang/pull/1047
Fix for https://issues.apache.org/jira/browse/LANG-1681
Some methods using Validate.nonNull not refering to NullPointerException in javadoc comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499441657
@kinow : I'm not a git-pro but I'll squash the build fix with all commits of @dvmarcilio into one single commit and force-push to my repo if it's OK for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1493844790
## [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1047?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1047](https://codecov.io/gh/apache/commons-lang/pull/1047?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a26c77f) into [master](https://codecov.io/gh/apache/commons-lang/commit/fee35ddc141a65a4956290864598e825214c4cff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fee35dd) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1047 +/- ##
=========================================
Coverage 92.06% 92.06%
Complexity 7484 7484
=========================================
Files 194 194
Lines 15725 15725
Branches 2897 2897
=========================================
Hits 14478 14478
Misses 674 674
Partials 573 573
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/1047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/commons/lang3/reflect/FieldUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9GaWVsZFV0aWxzLmphdmE=) | `93.33% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499359536
> I pushed modifications for all relevant cases that my tool could find.
I'll do checks on this soon.
Many thanks for the job done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1498775587
Hi @dvmarcilio
>I'm rerunning the tool on the latest commit. I'll be happy to submit more PRs fixing what it finds. Then we can finally close LANG-1681.
>Should I submit one PR per class or a single (possibly large) PR for all findings?
That could result in a lot of similar PRs, which would spam others that follow every message/commit/etc sent to the ASF mailing lists. Would you be able to provide this list here? Then @laurentschoelens can see whether that can be added to this PR, or maybe you could send an extra commit/diff here.
As for the missing throws I think we can also add it here (noting that we have to verify first whether we document every runtime error or not - some libraries may decide to document everything, while others document only a few like NPE, IllegalArgument, etc).
Cheers
Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499427559
>Error: src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java:[837] (regexp) RegexpSingleline: Line has trailing spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499246752
> > Could you tell me how to do it ?
>
> This should work: [Inviting collaborators to a personal repository](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-access-to-your-personal-repositories/inviting-collaborators-to-a-personal-repository) However, I'm unsure if you can give permission to a single branch. If that's the case, I promise not to touch other branches :)
Done, enjoy 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] dvmarcilio commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "dvmarcilio (via GitHub)" <gi...@apache.org>.
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499240289
> Could you tell me how to do it ?
This should work: [Inviting collaborators to a personal repository](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-access-to-your-personal-repositories/inviting-collaborators-to-a-personal-repository)
However, I'm unsure if you can give permission to a single branch.
If that's the case, I promise not to touch other branches :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1493857222
Hi @kinow,
Since the issue is on the commons-lang component and only mentioning it, I think it only concerns the commons-lang module.
I've found these 4 methods with Validate.nonNull with only IllegalArgumentException. But not sure if there are others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499256524
Hi @kinow, work done by @dvmarcilio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] dvmarcilio commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "dvmarcilio (via GitHub)" <gi...@apache.org>.
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499227307
@laurentschoelens, could you please give me permissions on your fork's branch `LANG-1681` so I can add more commits to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] dvmarcilio commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "dvmarcilio (via GitHub)" <gi...@apache.org>.
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1498740949
Thanks, @laurentschoelens for fixing these and @kinow for pinging me.
These 4 methods were among my tool findings.
I'm rerunning the tool on the latest commit. I'll be happy to submit more PRs fixing what it finds. Then we can finally close LANG-1681.
Should I submit one PR per class or a single (possibly large) PR for all findings?
The tool also finds missing `@throws`. I can submit different PRs for those as well.
Does that sound good to you, @kinow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499444414
> @kinow : I'm not a git-pro but I'll squash the build fix with all commits of @dvmarcilio into one single commit and force-push to my repo if it's OK for you
Done. And build should be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499231171
> @laurentschoelens, could you please give me permissions on your fork's branch `LANG-1681` so I can add more commits to it?
Could you tell me how to do it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] kinow commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499373669
Great team work! I've triggered the workflow to run, and will take a look at this PR later today. Thanks :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] dvmarcilio commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods
Posted by "dvmarcilio (via GitHub)" <gi...@apache.org>.
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499356798
I pushed modifications for all relevant cases that my tool could find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org