You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "jorgehermo9 (via GitHub)" <gi...@apache.org> on 2025/04/20 12:41:22 UTC
[PR] feat(services/gdrive): Add operation in http context [opendal]
jorgehermo9 opened a new pull request, #6068:
URL: https://github.com/apache/opendal/pull/6068
Relates to #5774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "jorgehermo9 (via GitHub)" <gi...@apache.org>.
jorgehermo9 commented on code in PR #6068:
URL: https://github.com/apache/opendal/pull/6068#discussion_r2051715640
##########
core/src/services/gdrive/core.rs:
##########
@@ -242,6 +249,7 @@ impl GdriveCore {
.header(header::CONTENT_TYPE, "application/octet-stream")
.header(header::CONTENT_LENGTH, size)
.header("X-Upload-Content-Length", size)
+ .extension(Operation::Write)
Review Comment:
I really do like this chained syntax, a lot more cleaner than `let req = ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #6068:
URL: https://github.com/apache/opendal/pull/6068#discussion_r2051736510
##########
core/src/services/gdrive/backend.rs:
##########
@@ -169,7 +169,9 @@ impl Access for GdriveBackend {
});
let body = Buffer::from(Bytes::from(request_body.to_string()));
+ // TODO: move this request to core.rs
Review Comment:
Yes, we can perform the refactor first.
##########
core/src/services/gdrive/core.rs:
##########
@@ -371,6 +379,7 @@ impl PathQuery for GdrivePathQuery {
);
let mut req = Request::get(&url)
+ .extension(Operation::Stat)
Review Comment:
It's `Stat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "jorgehermo9 (via GitHub)" <gi...@apache.org>.
jorgehermo9 commented on code in PR #6068:
URL: https://github.com/apache/opendal/pull/6068#discussion_r2051715786
##########
core/src/services/gdrive/backend.rs:
##########
@@ -169,7 +169,9 @@ impl Access for GdriveBackend {
});
let body = Buffer::from(Bytes::from(request_body.to_string()));
+ // TODO: move this request to core.rs
Review Comment:
I think this request should be in core.rs. Similar to https://github.com/apache/opendal/pull/6063#discussion_r2051703445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "jorgehermo9 (via GitHub)" <gi...@apache.org>.
jorgehermo9 commented on PR #6068:
URL: https://github.com/apache/opendal/pull/6068#issuecomment-2833331614
Merged with the refactor!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "jorgehermo9 (via GitHub)" <gi...@apache.org>.
jorgehermo9 commented on code in PR #6068:
URL: https://github.com/apache/opendal/pull/6068#discussion_r2061261665
##########
core/src/services/gdrive/backend.rs:
##########
@@ -169,7 +169,9 @@ impl Access for GdriveBackend {
});
let body = Buffer::from(Bytes::from(request_body.to_string()));
+ // TODO: move this request to core.rs
Review Comment:
https://github.com/apache/opendal/pull/6088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6068:
URL: https://github.com/apache/opendal/pull/6068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(services/gdrive): Add operation in http context [opendal]
Posted by "jorgehermo9 (via GitHub)" <gi...@apache.org>.
jorgehermo9 commented on code in PR #6068:
URL: https://github.com/apache/opendal/pull/6068#discussion_r2051715709
##########
core/src/services/gdrive/core.rs:
##########
@@ -371,6 +379,7 @@ impl PathQuery for GdrivePathQuery {
);
let mut req = Request::get(&url)
+ .extension(Operation::Stat)
Review Comment:
I'm really not sure of what operation type should we put here. `Stat`? `List`? `Info`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org