You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Steve Hay <st...@uk.radan.com> on 2003/08/21 12:49:44 UTC
[PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Hi,
I've just checked out the latest libapreq-1.2 from CVS and found that it
still hasn't been fixed to build with the latest version of
ExtUtils-MakeMaker that is being included in Perl 5.8.1 (currently 6.16,
I think).
There was a long discussion about the cause of it, and various possible
solutions, a while ago. The thread starts here:
http://marc.theaimsgroup.com/?l=apache-modperl&m=105964648404212&w=2
I think the simplest solution for the time being (proposed by Schwern in
that thread) was to correct the shameless hack that is being done in
c/Makefile.PL: The lines that are being hacked about have changed
slightly in format, so the hacking needs to be changed to suit.
The attached patch (against CVS) implements that suggestion, and enables
me to build 1.2 OK with MM 6.16.
Cheers,
- Steve
Re: [PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:
> Joe Schaefer wrote:
>
>> Stas Bekman <st...@stason.org> writes:
>>
>>
>>
>>> Not, so fast. Won't it break the hack for older perls with older
>>> MakeMaker?
>>>
>>
>>
>> It shouldn't- for older MakeMakers it should have the same effect
>> as the current code. At least that's my impression of the discussion
>> to date.
>>
> I agree. To quote Schwern in his original suggestion:
>
> ===
> 6.05 and previous had this:
>
> dynamic :: Makefile $(INST_DYNAMIC) $(INST_BOOT)
>
> 6.06_01 and up have this
>
> dynamic :: $(FIRST_MAKEFILE) $(INST_DYNAMIC) $(INST_BOOT)
> ===
>
> The patch changed a substitution that was looking for the bit to keep
> ("Makefile" or "$(FIRST_MAKEFILE)", which changed) to a pair of
> substitutions looking for the bits to lop off ("$(INST_DYNAMIC)" and
> "$(INST_BOOT)", which didn't change), so it should be fine.
That's cool then. Thanks for the explanation, Steve.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Posted by Steve Hay <st...@uk.radan.com>.
Joe Schaefer wrote:
>Stas Bekman <st...@stason.org> writes:
>
>
>
>>Not, so fast. Won't it break the hack for older perls with older
>>MakeMaker?
>>
>>
>
>It shouldn't- for older MakeMakers it should have the same effect
>as the current code. At least that's my impression of the discussion
>to date.
>
I agree. To quote Schwern in his original suggestion:
===
6.05 and previous had this:
dynamic :: Makefile $(INST_DYNAMIC) $(INST_BOOT)
6.06_01 and up have this
dynamic :: $(FIRST_MAKEFILE) $(INST_DYNAMIC) $(INST_BOOT)
===
The patch changed a substitution that was looking for the bit to keep
("Makefile" or "$(FIRST_MAKEFILE)", which changed) to a pair of
substitutions looking for the bits to lop off ("$(INST_DYNAMIC)" and
"$(INST_BOOT)", which didn't change), so it should be fine.
Re: [PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Stas Bekman <st...@stason.org> writes:
> Not, so fast. Won't it break the hack for older perls with older
> MakeMaker?
It shouldn't- for older MakeMakers it should have the same effect
as the current code. At least that's my impression of the discussion
to date.
> One solution is to make that recent MM version a prerequisite.
I don't believe we need to do that, but if the patch doesn't work
with older MM's, we probably should.
--
Joe Schaefer
Re: [PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Posted by Stas Bekman <st...@stason.org>.
Joe Schaefer wrote:
> Steve Hay <st...@uk.radan.com> writes:
>
> [...]
>
>
>>I think the simplest solution for the time being (proposed by Schwern
>>in that thread) was to correct the shameless hack that is being done
>>in c/Makefile.PL: The lines that are being hacked about have changed
>>slightly in format, so the hacking needs to be changed to suit.
>
>
> Agreed- this patch is the simplest fix. I'll apply it tomorrow
> unless someone else is working on a more ambitious solution.
Not, so fast. Won't it break the hack for older perls with older MakeMaker?
One solution is to make that recent MM version a prerequisite.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: [PATCH] Fix building libapreq-1.2 with latest ExtUtils-MakeMaker's
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Steve Hay <st...@uk.radan.com> writes:
[...]
> I think the simplest solution for the time being (proposed by Schwern
> in that thread) was to correct the shameless hack that is being done
> in c/Makefile.PL: The lines that are being hacked about have changed
> slightly in format, so the hacking needs to be changed to suit.
Agreed- this patch is the simplest fix. I'll apply it tomorrow
unless someone else is working on a more ambitious solution.
--
Joe Schaefer