You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/25 10:37:43 UTC

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6511: esp32_board_spi:Missing Data Command pin support

adamkaliszan commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r906666610


##########
boards/xtensa/esp32/common/src/esp32_board_spi.c:
##########
@@ -71,7 +71,7 @@ static inline uint8_t spi_status(struct spi_dev_s *dev, uint32_t devid)
 static inline int spi_cmddata(struct spi_dev_s *dev, uint32_t devid,
                               bool cmd)
 {
-#ifdef CONFIG_LCD_ILI9341
+#if defined(CONFIG_LCD_ILI9341) || defined(CONFIG_LCD_SSD1680)

Review Comment:
   I Would like to use **CONFIG_SSD1680_GPIO_PIN_DTA_CMD** instead of **DISPLAY_DC**. The **CONFIG_SSD1680_GPIO_PIN_DTA_CMD** is provided by Kconfig. Do I need to use DISPLAY_DC ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org