You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/10 17:29:39 UTC
[GitHub] [kafka] nicktelford opened a new pull request, #12842: MINOR: Fix double iteration of restoring records
nicktelford opened a new pull request, #12842:
URL: https://github.com/apache/kafka/pull/12842
While restoring a batch of records, `RocksDBStore` was iterating the `ConsumerRecord`s, building a list of `KeyValue`s, and then iterating _that_ list of `KeyValue`s to add them to the RocksDB batch.
Simply adding the key and value directly to the RocksDB batch prevents this unnecessary second iteration, and the creation of itermediate `KeyValue` objects, improving the performance of state restoration, and reducing unnecessary object allocation.
This also simplifies the API of `RocksDBAccessor`, as `prepareBatchForRestore` is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #12842: KAFKA-14406: Fix double iteration of restoring records
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on PR #12842:
URL: https://github.com/apache/kafka/pull/12842#issuecomment-1320799136
test failures are unrelated, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] nicktelford commented on pull request #12842: MINOR: Fix double iteration of restoring records
Posted by GitBox <gi...@apache.org>.
nicktelford commented on PR #12842:
URL: https://github.com/apache/kafka/pull/12842#issuecomment-1310644429
I wasn't sure if this warranted a JIRA ticket, since it's very small. I've not included any tests because there should not be any behavioural changes here, and I expect the existing test suite to pick up on any regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #12842: MINOR: Fix double iteration of restoring records
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on PR #12842:
URL: https://github.com/apache/kafka/pull/12842#issuecomment-1320560081
I think this might need a ticket. If you don't mind creating one. It would be good to track this to see when we get the fix in and what branches it's on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #12842: KAFKA-14406: Fix double iteration of restoring records
Posted by GitBox <gi...@apache.org>.
ableegoldman merged PR #12842:
URL: https://github.com/apache/kafka/pull/12842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] nicktelford commented on pull request #12842: KAFKA-14406: Fix double iteration of restoring records
Posted by GitBox <gi...@apache.org>.
nicktelford commented on PR #12842:
URL: https://github.com/apache/kafka/pull/12842#issuecomment-1321789047
@ableegoldman Thanks. My JIRA username is `nicktelford`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org