You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2006/11/02 03:13:00 UTC
[jira] Created: (WW-1488) ASF Source Header and Copyright Notice
Policy
ASF Source Header and Copyright Notice Policy
---------------------------------------------
Key: WW-1488
URL: http://issues.apache.org/struts/browse/WW-1488
Project: Struts 2
Issue Type: Task
Affects Versions: 2.0.1
Reporter: Niall Pemberton
Priority: Minor
Fix For: 2.0.2
All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
http://www.apache.org/legal/src-headers.html
Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
http://tinyurl.com/yf3pem
http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=all ]
Ted Husted resolved WW-1488.
----------------------------
Resolution: Fixed
r471148, r471740, r471754 (s1), r471756 (s2)
Also added NOTICE.txt and LICENSE.txt to struts2-blank, since we distribute the WAR independantly.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=all ]
Niall Pemberton updated WW-1488:
--------------------------------
Priority: Blocker (was: Minor)
Wendy pointed out that this is a blocker, since we shouldn't do another release without complying with the policy. Also in the FAQ page in the policy doc, theres script(s) to do this - for those who know/use python
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38591 ]
Ted Husted commented on WW-1488:
--------------------------------
The documentent says
"Each source file should include the following license header -- note that there should be no copyright notice in the header:"
In a policy document, should means "nice to have" and "must" means required. Or, at least that's what the words should mean :)
I'm looking at the scripts now, though I very much doubt this is going to be "five minutes work, if that".
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38588 ]
Niall Pemberton commented on WW-1488:
-------------------------------------
I don't read it the way you do - looks like a must to me:
In the FAQ is says "All releases created and distributed after November 1, 2006 must comply with this policy." and the policy clearly states no ASF copyright notices in source files. Nothing I read there says its optional.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38587 ]
Ted Husted commented on WW-1488:
--------------------------------
The point about not including copyright notices in source files is marked "should" in the policy documentation, which is a different meaning than "must". There are also exclusions noted as to the policy as to removing copyright notices from source files. So, personally, I would not consider addressing the copyright notices in existing source code files a blocker. We are removing the copyright statements because they cause confusion, not because they impune the legal status of the source files.
Through the FAQ, the policy documentation does require the licensing notice in bundled documentation file, if only as a comment in the HTML source. The Struts 1 documentation carries the notice in the XML source, but that is not carried forward by Maven during the HTML transformation. So, that point would have to be addressed before another Struts 1 release.
As to the Struts 2 documentation licensing notice, which would be a blocker, I added the notice to the autoexport template as an HTML comment and refreshed the export, so we are set on that score.
-Ted.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38592 ]
Ted Husted commented on WW-1488:
--------------------------------
I'm getting a fresh checkout of the HEAD, and I'll try to apply the Perl script mentioned in the document.
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "James Mitchell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38533 ]
James Mitchell commented on WW-1488:
------------------------------------
I ran rat against a clean checkout...
http://people.apache.org/~jmitchell/rat/
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WW-1488) ASF Source Header and Copyright Notice
Policy
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1488?page=comments#action_38609 ]
Niall Pemberton commented on WW-1488:
-------------------------------------
Thanks Ted!
> ASF Source Header and Copyright Notice Policy
> ---------------------------------------------
>
> Key: WW-1488
> URL: http://issues.apache.org/struts/browse/WW-1488
> Project: Struts 2
> Issue Type: Task
> Affects Versions: 2.0.1
> Reporter: Niall Pemberton
> Priority: Blocker
> Fix For: 2.0.2
>
>
> All the ASF License headers in the source files need to be updated to remove the copyright notice as per the new policy:
> http://www.apache.org/legal/src-headers.html
> Might also be a good idea to run Robert Burrell Donkin's "RAT" (release audit tool) on Struts, since we were singled out on the incubator list recently
> http://tinyurl.com/yf3pem
> http://code.google.com/p/arat/
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira