You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by "cdouine39 (via GitHub)" <gi...@apache.org> on 2023/06/01 12:42:50 UTC

[GitHub] [royale-asjs] cdouine39 opened a new pull request, #1225: Change type of _tempIR

cdouine39 opened a new pull request, #1225:
URL: https://github.com/apache/royale-asjs/pull/1225

   When using datagrid with grouping, I had an error here since _tempIR is not a ILabelFieldItemRenderer but a AdvancedDataGridItemRenderer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [royale-asjs] cdouine39 closed pull request #1225: Change type of _tempIR

Posted by "cdouine39 (via GitHub)" <gi...@apache.org>.
cdouine39 closed pull request #1225: Change type of _tempIR
URL: https://github.com/apache/royale-asjs/pull/1225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [royale-asjs] greg-dove commented on pull request #1225: Change type of _tempIR

Posted by "greg-dove (via GitHub)" <gi...@apache.org>.
greg-dove commented on PR #1225:
URL: https://github.com/apache/royale-asjs/pull/1225#issuecomment-1580221987

   > @greg-dove do you have time to approve that ? It looks reasonable.
   
   Sorry, @piotrzarzycki21 I can't do thorough review. I'm afk for at least 5 days while traveling, and so currently unable to compile or test anything. I also need to set up with new laptop etc when I arrive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [royale-asjs] piotrzarzycki21 commented on pull request #1225: Change type of _tempIR

Posted by "piotrzarzycki21 (via GitHub)" <gi...@apache.org>.
piotrzarzycki21 commented on PR #1225:
URL: https://github.com/apache/royale-asjs/pull/1225#issuecomment-1580123436

   @greg-dove do you have time to approve that ? It looks reasonable. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [royale-asjs] cdouine39 commented on pull request #1225: Change type of _tempIR

Posted by "cdouine39 (via GitHub)" <gi...@apache.org>.
cdouine39 commented on PR #1225:
URL: https://github.com/apache/royale-asjs/pull/1225#issuecomment-1594548087

   I'm having second thoughts about this PR, I'm not sure it would work in all cases. I'll reopen if this really works after more testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org