You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Arvind Prabhakar (Created) (JIRA)" <ji...@apache.org> on 2011/10/25 22:16:32 UTC
[jira] [Created] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Derby schema handler should create the necessary indexes for fast lookups.
--------------------------------------------------------------------------
Key: FLUME-821
URL: https://issues.apache.org/jira/browse/FLUME-821
Project: Flume
Issue Type: Improvement
Reporter: Arvind Prabhakar
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160198#comment-13160198 ]
Arvind Prabhakar commented on FLUME-821:
----------------------------------------
Attached the updated patch with review feedback.
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch, FLUME-821-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-821:
-----------------------------------
Fix Version/s: NG alpha 2
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160258#comment-13160258 ]
Hudson commented on FLUME-821:
------------------------------
Integrated in flume-728 #63 (See [https://builds.apache.org/job/flume-728/63/])
FLUME-821. Support for creating indexes in JDBC channel.
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1208624
Files :
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java
* /incubator/flume/branches/flume-728/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch, FLUME-821-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-821:
-----------------------------------
Attachment: FLUME-821-2.patch
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch, FLUME-821-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-821:
-----------------------------------
Attachment: FLUME-821-1.patch
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-821:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed.
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch, FLUME-821-2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160195#comment-13160195 ]
jiraposter@reviews.apache.org commented on FLUME-821:
-----------------------------------------------------
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. > Maybe a tweak on the log message level - up to you. Otherwise, lgtm!
Thanks for the reivew Eric. My comments follow.
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 120
bq. > <https://reviews.apache.org/r/2938/diff/1/?file=60141#file60141line120>
bq. >
bq. > Is this really a warning or just INFO?
Will change it before commit.
bq. On 2011-11-30 18:04:58, Eric Sammer wrote:
bq. > flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java, line 143
bq. > <https://reviews.apache.org/r/2938/diff/1/?file=60140#file60140line143>
bq. >
bq. > Should all of these constants (at some future point) be broken out into an external properties file for simpler updating? Just food for thought.
This is an implementation specific constant. Hence it is private scoped within the schema handler.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2938/#review3579
-----------------------------------------------------------
On 2011-11-27 05:25:12, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2938/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-27 05:25:12)
bq.
bq.
bq. Review request for Flume and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This change introduces the ability to create indexes while schema creation via the derby schema handler. The implementation defaults to the creation of indexes which can be turned off via configuration.
bq.
bq.
bq. This addresses bug FLUME-821.
bq. https://issues.apache.org/jira/browse/FLUME-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 7e0b3ac
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 7b29c7d
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java c1bc400
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1065ef9
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 68946c9
bq. flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 9ce6d16
bq.
bq. Diff: https://reviews.apache.org/r/2938/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests run successfully.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-821) Derby schema handler should create the
necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar updated FLUME-821:
-----------------------------------
Status: Patch Available (was: Open)
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157663#comment-13157663 ]
jiraposter@reviews.apache.org commented on FLUME-821:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2938/
-----------------------------------------------------------
Review request for Flume and Prasad Mujumdar.
Summary
-------
This change introduces the ability to create indexes while schema creation via the derby schema handler. The implementation defaults to the creation of indexes which can be turned off via configuration.
This addresses bug FLUME-821.
https://issues.apache.org/jira/browse/FLUME-821
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 7e0b3ac
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 7b29c7d
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java c1bc400
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1065ef9
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 68946c9
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 9ce6d16
Diff: https://reviews.apache.org/r/2938/diff
Testing
-------
All unit tests run successfully.
Thanks,
Arvind
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned FLUME-821:
--------------------------------------
Assignee: Arvind Prabhakar
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-821) Derby schema handler should create
the necessary indexes for fast lookups.
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160192#comment-13160192 ]
jiraposter@reviews.apache.org commented on FLUME-821:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2938/#review3579
-----------------------------------------------------------
Ship it!
Maybe a tweak on the log message level - up to you. Otherwise, lgtm!
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
<https://reviews.apache.org/r/2938/#comment7991>
Should all of these constants (at some future point) be broken out into an external properties file for simpler updating? Just food for thought.
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
<https://reviews.apache.org/r/2938/#comment7992>
Is this really a warning or just INFO?
- Eric
On 2011-11-27 05:25:12, Arvind Prabhakar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2938/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-27 05:25:12)
bq.
bq.
bq. Review request for Flume and Prasad Mujumdar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This change introduces the ability to create indexes while schema creation via the derby schema handler. The implementation defaults to the creation of indexes which can be turned off via configuration.
bq.
bq.
bq. This addresses bug FLUME-821.
bq. https://issues.apache.org/jira/browse/FLUME-821
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 7e0b3ac
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 7b29c7d
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java c1bc400
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1065ef9
bq. flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 68946c9
bq. flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 9ce6d16
bq.
bq. Diff: https://reviews.apache.org/r/2938/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests run successfully.
bq.
bq.
bq. Thanks,
bq.
bq. Arvind
bq.
bq.
> Derby schema handler should create the necessary indexes for fast lookups.
> --------------------------------------------------------------------------
>
> Key: FLUME-821
> URL: https://issues.apache.org/jira/browse/FLUME-821
> Project: Flume
> Issue Type: Improvement
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: NG alpha 2
>
> Attachments: FLUME-821-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira