[GitHub] [spark] turboFei edited a comment on pull request #31054: [SPARK-33100][SQL][FOLLOWUP] Find correct bound of bracketed comment in spark-sql

[GitBox <gi...@apache.org>]

turboFei edited a comment on pull request #31054:
URL: https://github.com/apache/spark/pull/31054#issuecomment-755290871


   according to the log you attached(https://github.com/apache/spark/pull/31045/checks?check_run_id=1652972350),
   we can see that there are two continuous queries, it is abnormal.
   ![image](https://user-images.githubusercontent.com/6757692/103771567-ed1c3d00-5062-11eb-92d4-fa8c456685ff.png)
   
   Is it possible that, for the CliSuite, we launch a process for test and write all queries into the outputstream of this process, 
   might the process stuck(might caused by the issue fixed by this pr?) some moment, and two continuous lines inputed and then only one result returned at last.
   
   https://github.com/apache/spark/blob/6788304240c416d173ebdb3d544f3361c6b9fe8e/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala#L167-L172
   
   
   Is it better to change it to?
   ```
       val stdinWriter = new OutputStreamWriter(process.getOutputStream, StandardCharsets.UTF_8)
       queriesLineList.foreach { queryLine =>
           stdinWriter.write(queryLine)
           stdinWriter.flush()
        }
       stdinWriter.close()
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org