[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #2173:
URL: https://github.com/apache/ignite-3/pull/2173#discussion_r1224219334


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngine.java:
##########
@@ -39,19 +39,16 @@ public String name() {
         return ENGINE_NAME;
     }
 
-    /** {@inheritDoc} */
     @Override
     public void start() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public void stop() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public MvTableStorage createMvTable(TableConfiguration tableCfg, TablesConfiguration tablesCfg,

Review Comment:
   For now, I suggest leaving it as is in IGNITE-19483 will be changed to pass catalog descriptors instead of configuration.
   
   Instead of **tablesCfg** there will be either some temporary interface or a configuration will remain, I think it's more of an interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org