You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by chaitali <ch...@freestoneinfotech.com> on 2021/02/08 16:33:51 UTC

Review Request 73177: ATLAS-4148 : [Atlas: Glossary Term Bulk Import] Incorrect error code displayed when no data found in the uploaded file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73177/
-----------------------------------------------------------

Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4148
    https://issues.apache.org/jira/browse/ATLAS-4148


Repository: atlas


Description
-------

This patch fix following bug : 

GlossaryName, TermName, ShortDescription, LongDescription, Examples, Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
This file is written for testing supported format with incorrect data format.
So this file contains some random text.
 
When this file is used as an input, the error code displayed is incorrect:

{
    "errorCode":"ATLAS-404-00-014",
    "errorMessage":"No data found in the uploaded file"
}

Expectation:

Since this is client side error 400 should be displayed


Diffs
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917 


Diff: https://reviews.apache.org/r/73177/diff/1/


Testing
-------

Tested with above format data and expected errorcode was thrown


Thanks,

chaitali