You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mehrdad Nurolahzade <me...@nurolahzade.com> on 2016/12/22 20:56:32 UTC

Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Stephan Erb.


Bugs: AURORA-1828
    https://issues.apache.org/jira/browse/AURORA-1828


Repository: aurora


Description
-------

AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 

Diff: https://reviews.apache.org/r/54995/diff/


Testing
-------


Thanks,

Mehrdad Nurolahzade


Re: Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review160150
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Dec. 22, 2016, 9:56 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54995/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 9:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1828
>     https://issues.apache.org/jira/browse/AURORA-1828
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 
> 
> Diff: https://reviews.apache.org/r/54995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review160013
-----------------------------------------------------------


Ship it!




Master (61e6bc6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 22, 2016, 8:56 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54995/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 8:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1828
>     https://issues.apache.org/jira/browse/AURORA-1828
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 
> 
> Diff: https://reviews.apache.org/r/54995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review162694
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Dec. 22, 2016, 8:56 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54995/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 8:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1828
>     https://issues.apache.org/jira/browse/AURORA-1828
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 
> 
> Diff: https://reviews.apache.org/r/54995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review162673
-----------------------------------------------------------


Ship it!




Ship It!

- David McLaughlin


On Dec. 22, 2016, 8:56 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54995/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 8:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1828
>     https://issues.apache.org/jira/browse/AURORA-1828
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 
> 
> Diff: https://reviews.apache.org/r/54995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Re: Review Request 54995: AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned

Posted by Mehrdad Nurolahzade <me...@nurolahzade.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54995/#review162652
-----------------------------------------------------------



Ping!

- Mehrdad Nurolahzade


On Dec. 22, 2016, 12:56 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54995/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 12:56 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1828
>     https://issues.apache.org/jira/browse/AURORA-1828
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1828 Expose stats on the number of offers evaluated before a task is assigned
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java c1e7b0377b6bc0084b3810351e81916b7a7e4374 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java b482be52518c40a0e9d2206bf52bcbb4ad94f46d 
> 
> Diff: https://reviews.apache.org/r/54995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>