You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/12/15 08:52:49 UTC
[GitHub] [incubator-celeborn] nafiyAix opened a new pull request, #1093: [CELEBORN-145][REFACTOR] Add reason in CheckQuotaResponse
nafiyAix opened a new pull request, #1093:
URL: https://github.com/apache/incubator-celeborn/pull/1093
### What changes were proposed in this pull request?
Add reason in CheckQuotaResponse return result and related unit test.
### Why are the changes needed?
To be convenient to check which parts of consumption exceed quota when shuffle fallback, and no need to check the server log for details each time when excessive quota happens.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Add unit test to check if quota can return correct result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1093: [CELEBORN-145][REFACTOR] Add reason in CheckQuotaResponse
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1093:
URL: https://github.com/apache/incubator-celeborn/pull/1093#discussion_r1049405492
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1291,15 +1291,15 @@ class LifecycleManager(appId: String, val conf: CelebornConf) extends RpcEndpoin
}
}
- def checkQuota(): Boolean = {
+ def checkQuota(): CheckQuotaResponse = {
try {
rssHARetryClient.askSync[CheckQuotaResponse](
CheckQuota(userIdentifier),
- classOf[CheckQuotaResponse]).isAvailable
+ classOf[CheckQuotaResponse])
} catch {
case e: Exception =>
logError(s"AskSync Cluster check quota for $userIdentifier failed.", e)
- false
+ CheckQuotaResponse(false, "")
Review Comment:
```
val msg = "AskSync Cluster check quota for $userIdentifier failed."
logError(msg, e)
CheckQuotaResponse(false, msg)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1093: [CELEBORN-145][REFACTOR] Add reason in CheckQuotaResponse
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu merged PR #1093:
URL: https://github.com/apache/incubator-celeborn/pull/1093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1093: [CELEBORN-145][REFACTOR] Add reason in CheckQuotaResponse
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1093:
URL: https://github.com/apache/incubator-celeborn/pull/1093#issuecomment-1352753039
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1093](https://codecov.io/gh/apache/incubator-celeborn/pull/1093?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b23d891) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e3576e4e7af10485c92f55ea8e585e986f23260b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3576e4) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1093 +/- ##
============================================
- Coverage 25.16% 25.06% -0.09%
Complexity 774 774
============================================
Files 215 215
Lines 18122 18194 +72
Branches 2033 2035 +2
============================================
+ Hits 4558 4559 +1
- Misses 13257 13328 +71
Partials 307 307
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1093?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/celeborn/client/LifecycleManager.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY2xpZW50L0xpZmVjeWNsZU1hbmFnZXIuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...born/common/protocol/message/ControlMessages.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | `0.14% <0.00%> (-<0.01%)` | :arrow_down: |
| [...scala/org/apache/celeborn/common/quota/Quota.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3F1b3RhL1F1b3RhLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...apache/celeborn/service/deploy/master/Master.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvbWFzdGVyL01hc3Rlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...born/service/deploy/worker/storage/FlushTask.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvRmx1c2hUYXNrLnNjYWxh) | `62.50% <0.00%> (-8.92%)` | :arrow_down: |
| [...born/service/deploy/worker/storage/FileWriter.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvc3RvcmFnZS9GaWxlV3JpdGVyLmphdmE=) | `36.50% <0.00%> (-0.36%)` | :arrow_down: |
| [...java/org/apache/celeborn/common/meta/FileInfo.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbWV0YS9GaWxlSW5mby5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pache/celeborn/client/read/DfsPartitionReader.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jbGllbnQvcmVhZC9EZnNQYXJ0aXRpb25SZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...leborn/service/deploy/worker/PushDataHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1B1c2hEYXRhSGFuZGxlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...leborn/service/deploy/worker/storage/Flusher.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL3N0b3JhZ2UvRmx1c2hlci5zY2FsYQ==) | `52.78% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-celeborn/pull/1093/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org