You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Ivan Pavlukhin <vo...@gmail.com> on 2020/02/01 07:26:52 UTC

Re: [IGNITE-12582] Configuration by property

Sergey,

I understand and support the proposed idea. Just curious how to
implement it. Do you already have some prototype?

пт, 31 янв. 2020 г. в 11:48, schernolyas <se...@gmail.com>:
>
> Hi!
>
> It is proposed to use the same annotation(RepositoryConfig). But value of
> field "cacheName"  can be constant or Spring EL expression.
> Correct cases are:
> 1) By Spring EL expression
> @Repository
> @RepositoryConfig(cacheName = "@cacheNames.calendarCacheName")
> public interface CalendarRepository extends IgniteRepository<Calendar,
> String> {
>     List<Calendar> findByName(String name);
> }
> 2) By constant
> @Repository
> @RepositoryConfig(cacheName = "Calendar")
> public interface CalendarRepository extends IgniteRepository<Calendar,
> String> {
>     List<Calendar> findByName(String name);
> }
>
> Any other ideas?
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/



-- 
Best regards,
Ivan Pavlukhin

Re: [IGNITE-12582] Configuration by property

Posted by Sergey Chernolyas <se...@gmail.com>.
Ivan,

Thanks. I have answered.


On Tue, 4 Feb 2020 at 15:03, Ivan Pavlukhin <vo...@gmail.com> wrote:

> Sergey,
>
> Thank you for your efforts! I left some comments in the ticket [1].
>
> [1] https://issues.apache.org/jira/browse/IGNITE-12582
>
> сб, 1 февр. 2020 г. в 18:35, Sergey Chernolyas <
> sergey.chernolyas@gmail.com>:
> >
> > Hi Ivan!
> >
> > https://github.com/apache/ignite/pull/7347 . It is link to PR.
> Criticism
> > is welcome :-)
> >
> > On Sat, 1 Feb 2020 at 18:15, Ivan Pavlukhin <vo...@gmail.com> wrote:
> >
> > > Sergey,
> > >
> > > Could you please share your prototype, I would like to have a look.
> > >
> > > сб, 1 февр. 2020 г. в 16:59, schernolyas <sergey.chernolyas@gmail.com
> >:
> > > >
> > > > Hi Ivan !
> > > >
> > > > Yes, I have the prototype.  Right now, main question is can we remove
> > > spring
> > > > data modules into project with extensions for Ignite.
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Ivan Pavlukhin
> > >
> >
> >
> > --
> > ---------------------
> >
> > With best regards, Sergey Chernolyas
>
>
>
> --
> Best regards,
> Ivan Pavlukhin
>


-- 
---------------------

With best regards, Sergey Chernolyas

Re: [IGNITE-12582] Configuration by property

Posted by Ivan Pavlukhin <vo...@gmail.com>.
Sergey,

Thank you for your efforts! I left some comments in the ticket [1].

[1] https://issues.apache.org/jira/browse/IGNITE-12582

сб, 1 февр. 2020 г. в 18:35, Sergey Chernolyas <se...@gmail.com>:
>
> Hi Ivan!
>
> https://github.com/apache/ignite/pull/7347 . It is link to PR.  Criticism
> is welcome :-)
>
> On Sat, 1 Feb 2020 at 18:15, Ivan Pavlukhin <vo...@gmail.com> wrote:
>
> > Sergey,
> >
> > Could you please share your prototype, I would like to have a look.
> >
> > сб, 1 февр. 2020 г. в 16:59, schernolyas <se...@gmail.com>:
> > >
> > > Hi Ivan !
> > >
> > > Yes, I have the prototype.  Right now, main question is can we remove
> > spring
> > > data modules into project with extensions for Ignite.
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
> >
> >
> > --
> > Best regards,
> > Ivan Pavlukhin
> >
>
>
> --
> ---------------------
>
> With best regards, Sergey Chernolyas



-- 
Best regards,
Ivan Pavlukhin

Re: [IGNITE-12582] Configuration by property

Posted by Sergey Chernolyas <se...@gmail.com>.
Hi Ivan!

https://github.com/apache/ignite/pull/7347 . It is link to PR.  Criticism
is welcome :-)

On Sat, 1 Feb 2020 at 18:15, Ivan Pavlukhin <vo...@gmail.com> wrote:

> Sergey,
>
> Could you please share your prototype, I would like to have a look.
>
> сб, 1 февр. 2020 г. в 16:59, schernolyas <se...@gmail.com>:
> >
> > Hi Ivan !
> >
> > Yes, I have the prototype.  Right now, main question is can we remove
> spring
> > data modules into project with extensions for Ignite.
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
>
>
> --
> Best regards,
> Ivan Pavlukhin
>


-- 
---------------------

With best regards, Sergey Chernolyas

Re: [IGNITE-12582] Configuration by property

Posted by Ivan Pavlukhin <vo...@gmail.com>.
Sergey,

Could you please share your prototype, I would like to have a look.

сб, 1 февр. 2020 г. в 16:59, schernolyas <se...@gmail.com>:
>
> Hi Ivan !
>
> Yes, I have the prototype.  Right now, main question is can we remove spring
> data modules into project with extensions for Ignite.
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/



-- 
Best regards,
Ivan Pavlukhin

Re: [IGNITE-12582] Configuration by property

Posted by schernolyas <se...@gmail.com>.
Hi Ivan !

Yes, I have the prototype.  Right now, main question is can we remove spring
data modules into project with extensions for Ignite.



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/