You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/16 18:45:38 UTC
[GitHub] aaronucsd commented on a change in pull request #3485: [TE] frontend harleyjj/manage remove WoW and change buildMetricDataUr…
aaronucsd commented on a change in pull request #3485: [TE] frontend harleyjj/manage remove WoW and change buildMetricDataUr…
URL: https://github.com/apache/incubator-pinot/pull/3485#discussion_r234309675
##########
File path: thirdeye/thirdeye-frontend/app/pods/components/anomaly-graph/component.js
##########
@@ -388,7 +388,7 @@ export default Component.extend({
const showGraphLegend = this.get('showGraphLegend');
return {
position: 'inset',
- show: showGraphLegend
+ show: false
Review comment:
We should have left `showGraphLegend` here. As it has changed to false. Also we do like the option for user decide to show the legend by specifying the showGraphLegend's value. Now we force it to not show with ` show: false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org