[GitHub] [spark] amaliujia commented on a diff in pull request #38193: [SPARK-39375][CONNECT][FOLLOW-UP] Refactor Read to UnresolvedRelation

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38193:
URL: https://github.com/apache/spark/pull/38193#discussion_r991673158


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -31,7 +31,7 @@ option java_package = "org.apache.spark.connect.proto";
 message Relation {
   RelationCommon common = 1;
   oneof rel_type {
-    Read read = 2;
+    UnresolvedRelation unresolved_relation = 2;

Review Comment:
   Per the review suggestions on https://github.com/apache/spark/pull/38086, we plan to decouple unresolved relation and data source (e.g. in different messages). cc @cloud-fan 
   
   Data source needs its own plan with its own fields. In that case current `Read` will only be unresolved relation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org