You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:37:01 UTC

[GitHub] [shiro] bdemers commented on a change in pull request #259: Update AbstractContainerIT to allow for HTTPS connections Using a pre-generated keystore

bdemers commented on a change in pull request #259:
URL: https://github.com/apache/shiro/pull/259#discussion_r505684521



##########
File path: integration-tests/support/src/main/resources/createKeyStore.sh
##########
@@ -0,0 +1,65 @@
+#!/usr/bin/env bash

Review comment:
       This script isn't run at build time, it just exists as a source for the keystore and pem as part of this commit.
   I'd rather create a keystore on the fly as needed by tests, but this was easier in the short term.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org