[GitHub] Menardi commented on a change in pull request #464: Unit tests for android_sdk and AndroidProject

[GitBox <gi...@apache.org>]

Menardi commented on a change in pull request #464: Unit tests for android_sdk and AndroidProject
URL: https://github.com/apache/cordova-android/pull/464#discussion_r199968826
 
 

 ##########
 File path: bin/templates/cordova/lib/android_sdk.js
 ##########
 @@ -95,7 +94,7 @@ module.exports.list_targets = function () {
         } else throw err;
     }).then(function (targets) {
         if (targets.length === 0) {
-            return Q.reject(new Error('No android targets (SDKs) installed!'));
+            return Promise.reject(new Error('No android targets (SDKs) installed!'));
 
 Review comment:
   I have no strong feelings either way. But, when replacing `Q`, I wanted to keep the changes as simple as possible. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org