You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/18 17:24:27 UTC

[GitHub] [solr] chriswininger commented on pull request #1076: Disable lift god classes

chriswininger commented on PR #1076:
URL: https://github.com/apache/solr/pull/1076#issuecomment-1282755707

   > Well interestingly #1083 doesn't have this god classes message and didn't have `refactor-first` - https://lift.sonatype.com/results/github.com/apache/solr/01GFKERWM0GPHVJMB30065RC6D?tab=tool-results. So maybe it is disabled but some PRs pickup the old changes...
   
   Yes, there are some minor issues with how lift handles cases where the toml is different between the source and target branch. This is an existing issue on our board. I suspect once this change is in main/master and the prs are up to date with it you will stop seeing the message. Sorry for the confusion and thanks for reaching out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org