You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 08:52:08 UTC

[GitHub] [flink] JingsongLi opened a new pull request #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

JingsongLi opened a new pull request #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841
 
 
   
   ## What is the purpose of the change
   
   In ExpressionConverter, we convert Flink expression to Calcite RexNode. For literal, Flink TinyInt/SmallInt literals are wrongly converted to Calcite Int/Int literals. This lead to incompatible types of expression and result type.
   
   ## Brief change log
   
   Fix tinyint/smallint/int literals in `ExpressionConverter.visit(ValueLiteralExpression)`.
   
   ## Verifying this change
   
   - `ExpressionConverter`
   - `OverWindowITCase.testOverWindowWithUDAG11G`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector:no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573572659
 
 
   <!--
   Meta data
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144117186 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   -->
   ## CI report:
   
   * d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144117186) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287) 
   * b5b112c7954d4961cfbc71f9d268a7a2561e6051 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573572659
 
 
   <!--
   Meta data
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144117186 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144134923 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   -->
   ## CI report:
   
   * d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144117186) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287) 
   * b5b112c7954d4961cfbc71f9d268a7a2561e6051 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144134923) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573564277
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d3abca3b9c9ca0ad030f7e208843502d14ff13a5 (Mon Jan 13 08:57:31 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573572659
 
 
   <!--
   Meta data
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144117186 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144134923 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   -->
   ## CI report:
   
   * d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144117186) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287) 
   * b5b112c7954d4961cfbc71f9d268a7a2561e6051 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144134923) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573572659
 
 
   <!--
   Meta data
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   -->
   ## CI report:
   
   * d3abca3b9c9ca0ad030f7e208843502d14ff13a5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841#issuecomment-573572659
 
 
   <!--
   Meta data
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144117186 TriggerType:PUSH TriggerID:d3abca3b9c9ca0ad030f7e208843502d14ff13a5
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   Hash:b5b112c7954d4961cfbc71f9d268a7a2561e6051 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144134923 TriggerType:PUSH TriggerID:b5b112c7954d4961cfbc71f9d268a7a2561e6051
   -->
   ## CI report:
   
   * d3abca3b9c9ca0ad030f7e208843502d14ff13a5 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144117186) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4287) 
   * b5b112c7954d4961cfbc71f9d268a7a2561e6051 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144134923) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4289) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt, SmallInt literals between Flink and Calcite

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10841: [FLINK-15565][table-planner-blink] Fix error conversion of TinyInt,SmallInt literals between Flink and Calcite
URL: https://github.com/apache/flink/pull/10841
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services