You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2008/09/24 15:02:44 UTC
[jira] Created: (HADOOP-4262) message generated when the client
exception has a null message is not useful
message generated when the client exception has a null message is not useful
----------------------------------------------------------------------------
Key: HADOOP-4262
URL: https://issues.apache.org/jira/browse/HADOOP-4262
Project: Hadoop Core
Issue Type: Bug
Components: ipc
Affects Versions: 0.19.0, 0.20.0
Reporter: Steve Loughran
Priority: Minor
This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634127#action_12634127 ]
Steve Loughran commented on HADOOP-4262:
----------------------------------------
fuller stack trace: [sf-startdaemon-debug] Caused by: java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client.call(Client.java:699)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.RPC$Invoker.invoke(RPC.java:216)
[sf-startdaemon-debug] at org.apache.hadoop.mapred.$Proxy6.getJobProfile(Unknown Source)
[sf-startdaemon-debug] at org.apache.hadoop.mapred.JobClient$NetworkedJob.<init>(JobClient.java:179)
[sf-startdaemon-debug] at org.apache.hadoop.mapred.JobClient.submitJob(JobClient.java:828)
[sf-startdaemon-debug] at org.smartfrog.services.hadoop.components.submitter.SubmitterImpl.sfStart(SubmitterImpl.java:104)
[sf-startdaemon-debug] ... 11 more
[sf-startdaemon-debug] Caused by: java.io.EOFException
[sf-startdaemon-debug] at java.io.DataInputStream.readInt(DataInputStream.java:375)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client$Connection.receiveResponse(Client.java:493)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client$Connection.run(Client.java:438)
I propose that if the getMessage() value is null, then instead the classname of the excepetion is picked up instead. So the expected text would be
Caused by: java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: java.io.EOFException
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-4262:
---------------------------------
Status: Open (was: Patch Available)
> It may make sense to extract this exception-to-text operation into a utils class
I think instead we should just use Throwable#toString().
http://java.sun.com/javase/6/docs/api/java/lang/Throwable.html#toString()
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-4262:
---------------------------------
Attachment: HADOOP-4262.patch
Here's a new version that uses Throwable#toString().
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636029#action_12636029 ]
Hudson commented on HADOOP-4262:
--------------------------------
Integrated in Hadoop-trunk #620 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/620/])
. Generate better error message when client exception has null
message. (stevel via omalley)
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-4262:
-----------------------------------
Fix Version/s: 0.20.0
Status: Patch Available (was: Open)
This patch changes the failure message to be the classname if there is no message in the exception itself:
[sf-startdaemon-debug] Caused by: java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: java.io.EOFException
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client.call(Client.java:699)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.RPC$Invoker.invoke(RPC.java:216)
[sf-startdaemon-debug] at org.apache.hadoop.mapred.$Proxy6.getJobProfile(Unknown Source)
[sf-startdaemon-debug] 08/09/24 15:43:13 [IPC Server handler 6 on 8012] INFO ipc.Server : IPC Server handler 6 on 8012: exiting
[sf-startdaemon-debug] 08/09/24 15:43:13 [IPC Server handler 1 on 8012] INFO ipc.Server : IPC Server handler 1 on 8012: exiting
[sf-startdaemon-debug] 08/09/24 15:43:13 [IPC Server handler 0 on 8012] INFO ipc.Server : IPC Server handler 0 on 8012: exiting
[sf-startdaemon-debug] at org.apache.hadoop.mapred.JobClient$NetworkedJob.<init>(JobClient.java:179)
[sf-startdaemon-debug] at org.apache.hadoop.mapred.JobClient.submitJob(JobClient.java:828)
[sf-startdaemon-debug] at org.smartfrog.services.hadoop.components.submitter.SubmitterImpl.sfStart(SubmitterImpl.java:104)
[sf-startdaemon-debug] ... 11 more
[sf-startdaemon-debug] Caused by: java.io.EOFException
[sf-startdaemon-debug] at java.io.DataInputStream.readInt(DataInputStream.java:375)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client$Connection.receiveResponse(Client.java:493)
[sf-startdaemon-debug] at org.apache.hadoop.ipc.Client$Connection.run(Client.java:438)
There's no test. It may make sense to extract this exception-to-text operation into a utils class where it could be reused and tested trivially.
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran updated HADOOP-4262:
-----------------------------------
Attachment: hadoop-4262.patch
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-4262:
---------------------------------
Status: Patch Available (was: Open)
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4262:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Steve!
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4262) message generated when the client
exception has a null message is not useful
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634289#action_12634289 ]
Hadoop QA commented on HADOOP-4262:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390850/HADOOP-4262.patch
against trunk revision 698677.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3363/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3363/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3363/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3363/console
This message is automatically generated.
> message generated when the client exception has a null message is not useful
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4262
> URL: https://issues.apache.org/jira/browse/HADOOP-4262
> Project: Hadoop Core
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.19.0, 0.20.0
> Reporter: Steve Loughran
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HADOOP-4262.patch, hadoop-4262.patch
>
>
> This was created by HADOOP-3844; if the exception doesn't have a meaningful message, the output isn't that informative :
> java.io.IOException: Call to localhost/127.0.0.1:8012 failed on local exception: null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.