You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/02/04 21:12:09 UTC
Review Request 65503: Added bootstrap-table library for the WebUI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-8486
https://issues.apache.org/jira/browse/MESOS-8486
Repository: mesos
Description
-------
This library extends the properties of the tables provided by Bootstrap.
Link to the library repo: https://github.com/wenzhixin/bootstrap-table.
Bootstrap Table is licensed under the The MIT License.
Diffs
-----
src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
support/mesos-style.py 1b34ea2d9afa8f17b545841cea7a6853a6e18144
Diff: https://reviews.apache.org/r/65503/diff/1/
Testing
-------
Tested in the dependent review request /r/65346/
Thanks,
Armand Grillet
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review197633
-----------------------------------------------------------
src/Makefile.am
Lines 1785-1786 (original), 1785-1786 (patched)
<https://reviews.apache.org/r/65503/#comment277854>
Don't you need the CSS here?
- Benjamin Mahler
On Feb. 11, 2018, 4:15 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2018, 4:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This library extends the properties of the tables provided by Bootstrap.
>
>
> Diffs
> -----
>
> src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151
> src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
> support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984
>
>
> Diff: https://reviews.apache.org/r/65503/diff/2/
>
>
> Testing
> -------
>
> Tested in the dependent review request /r/65346/
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review197634
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 11, 2018, 4:15 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2018, 4:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This library extends the properties of the tables provided by Bootstrap.
>
>
> Diffs
> -----
>
> src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151
> src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
> support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984
>
>
> Diff: https://reviews.apache.org/r/65503/diff/2/
>
>
> Testing
> -------
>
> Tested in the dependent review request /r/65346/
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/
-----------------------------------------------------------
(Updated Feb. 11, 2018, 4:15 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Updated `src/Makefile.am`.
Bugs: MESOS-8486
https://issues.apache.org/jira/browse/MESOS-8486
Repository: mesos
Description (updated)
-------
This library extends the properties of the tables provided by Bootstrap.
Diffs (updated)
-----
src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151
src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984
Diff: https://reviews.apache.org/r/65503/diff/2/
Changes: https://reviews.apache.org/r/65503/diff/1-2/
Testing
-------
Tested in the dependent review request /r/65346/
Thanks,
Armand Grillet
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Armand Grillet <ag...@mesosphere.io>.
> On Feb. 6, 2018, 3:26 a.m., Benjamin Mahler wrote:
> > Looks good, couple of questions:
> >
> > (1) Doesn't this need to be part of the installation? I think you need to update the autotools and cmake builds?
> > (2) Do we need to update LICENSE to include this new sub-component?
1) Correct, I have modified `src/Makefile.am` in the new revision. No `CMakeLists.txt` file needs to be updated.
2) This is currently not done for JS libraries (I have checked for Angular). Should we do it for all our JS libraries in another patch?
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review196858
-----------------------------------------------------------
On Feb. 11, 2018, 4:15 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2018, 4:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This library extends the properties of the tables provided by Bootstrap.
>
>
> Diffs
> -----
>
> src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151
> src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
> support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984
>
>
> Diff: https://reviews.apache.org/r/65503/diff/2/
>
>
> Testing
> -------
>
> Tested in the dependent review request /r/65346/
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Feb. 6, 2018, 3:26 a.m., Benjamin Mahler wrote:
> > Looks good, couple of questions:
> >
> > (1) Doesn't this need to be part of the installation? I think you need to update the autotools and cmake builds?
> > (2) Do we need to update LICENSE to include this new sub-component?
>
> Armand Grillet wrote:
> 1) Correct, I have modified `src/Makefile.am` in the new revision. No `CMakeLists.txt` file needs to be updated.
> 2) This is currently not done for JS libraries (I have checked for Angular). Should we do it for all our JS libraries in another patch?
2) Sounds good, can you follow up?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review196858
-----------------------------------------------------------
On Feb. 11, 2018, 4:15 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2018, 4:15 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This library extends the properties of the tables provided by Bootstrap.
>
>
> Diffs
> -----
>
> src/Makefile.am 45f0480be0ccb9d9adf90a8a7468eb2dadc84151
> src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
> support/mesos-style.py d9e83d7c0cf6146f00ce7f1ab11b89880d105984
>
>
> Diff: https://reviews.apache.org/r/65503/diff/2/
>
>
> Testing
> -------
>
> Tested in the dependent review request /r/65346/
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65503: Added bootstrap-table library for the WebUI.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65503/#review196858
-----------------------------------------------------------
Looks good, couple of questions:
(1) Doesn't this need to be part of the installation? I think you need to update the autotools and cmake builds?
(2) Do we need to update LICENSE to include this new sub-component?
- Benjamin Mahler
On Feb. 4, 2018, 9:12 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65503/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2018, 9:12 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8486
> https://issues.apache.org/jira/browse/MESOS-8486
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This library extends the properties of the tables provided by Bootstrap.
> Link to the library repo: https://github.com/wenzhixin/bootstrap-table.
> Bootstrap Table is licensed under the The MIT License.
>
>
> Diffs
> -----
>
> src/webui/master/static/css/bootstrap-table-1.11.1.min.css PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.js PRE-CREATION
> src/webui/master/static/js/bootstrap-table-1.11.1.min.js PRE-CREATION
> support/mesos-style.py 1b34ea2d9afa8f17b545841cea7a6853a6e18144
>
>
> Diff: https://reviews.apache.org/r/65503/diff/1/
>
>
> Testing
> -------
>
> Tested in the dependent review request /r/65346/
>
>
> Thanks,
>
> Armand Grillet
>
>