You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/07 00:42:12 UTC
[jira] [Commented] (KAFKA-3312) Add a offsets methods to ZkUtils
and replace relevant usages
[ https://issues.apache.org/jira/browse/KAFKA-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274985#comment-15274985 ]
ASF GitHub Bot commented on KAFKA-3312:
---------------------------------------
GitHub user vahidhashemian reopened a pull request:
https://github.com/apache/kafka/pull/1025
KAFKA-3312: Add utility offset methods to ZkUtils
Create utility getOffset(...) and updateOffset(...) methods to replace readData(...), readDataMaybeNull(...) and updatePersistentPath(...) method calls where they deal with getting or setting offsets.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-3312
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1025
----
commit d379ef6944e7dbed930f97ff51f6c9f98e9f9376
Author: Vahid Hashemian <va...@us.ibm.com>
Date: 2016-03-05T00:47:05Z
KAFKA-3312: Add utility offset methods to ZkUtils
Create utility getOffset(...) and updateOffset(...) methods to replace readData(...), readDataMaybeNull(...) and updatePersistentPath(...) method calls where they deal with getting or setting offsets.
----
> Add a offsets methods to ZkUtils and replace relevant usages
> ------------------------------------------------------------
>
> Key: KAFKA-3312
> URL: https://issues.apache.org/jira/browse/KAFKA-3312
> Project: Kafka
> Issue Type: Improvement
> Reporter: Grant Henke
> Assignee: Vahid Hashemian
>
> There are many places in the code that manually build a zookeeper path and get or update offsets. Moving this logic to a common location in ZkUtils would be nice.
> Ex:
> {code}
> zkUtils.readDataMaybeNull(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}")._1
> {code}
> {code}
> zkUtils.readData(topicDirs.consumerOffsetDir + "/" + topicAndPartition.partition)._1.toLong
> {code}
> {code}
> zkUtils.updatePersistentPath(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}", partitionData.offset.toString)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)