[jira] [Commented] (NIFI-3742) PutDatabaseRecord can not delete row if it contains null value

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986835#comment-15986835 ] 

ASF GitHub Bot commented on NIFI-3742:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/1709

    NIFI-3742: Fixed handling of nulls in DELETE for PutDatabaseRecord

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-3742

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1709
    
----
commit 05cd13f0db51aa552c90abbedb910e0af57c7de1
Author: Matt Burgess <ma...@apache.org>
Date:   2017-04-27T15:36:47Z

    NIFI-3742: Fixed handling of nulls in DELETE for PutDatabaseRecord

----


> PutDatabaseRecord can not delete row if it contains null value
> --------------------------------------------------------------
>
>                 Key: NIFI-3742
>                 URL: https://issues.apache.org/jira/browse/NIFI-3742
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.2.0
>            Reporter: Koji Kawamura
>            Assignee: Matt Burgess
>
> For example, let's say a table which has null-able columns. When rows get deleted, CaptureChangeMySQL emits 'delete' events for each deleted row with all column values including null-able ones. From those data, PutDatabaseRecord can generate delete statements for other table which have where clause like this:
> {code}
> DELETE FROM users WHERE id = 4 AND title = null AND first = 'Koji' AND last = 'Kawamura' AND street = null AND city = null AND state = null AND zip = null AND gender = null AND email = null AND username = null AND password = null AND phone = null AND cell = null AND ssn = null AND date_of_birth = null AND reg_date = null AND large = null AND medium = null AND thumbnail = null AND version = null AND nationality = null
> {code}
> However, a condition like 'title = null' doesn't hit with any record, because for null value, we should use 'title IS null' instead.
> I think we should do something like below in order to treat these null-able columns:
> {code}
> # With a prepared statement like this:
> DELETE FROM users WHERE id = ? AND (title = ? OR (title is null AND ? is null)) AND ... so on ...;
> # Which is executed like this:
> DELETE FROM users WHERE id = 4 AND (title = null OR (title is null AND null is null)) … and so on …;
> {code}
> Reference:
> http://stackoverflow.com/questions/4215135/how-to-deal-with-maybe-null-values-in-a-preparedstatement



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)