[GitHub] reminisce commented on issue #8558: slice operator supporting arbitrary values of step

[GitBox <gi...@apache.org>]

reminisce commented on issue #8558: slice operator supporting arbitrary values of step
URL: https://github.com/apache/incubator-mxnet/pull/8558#issuecomment-342043664
 
 
   @cjolivier01 The time is for forward only, no backward (the backward kernel is essentially the same as the forward one). It includes shape/dtype inferences and forward function calls. There might be a few reasons that lead to more runtime in the new implementation:
   1. Infer shape function is more complicated than the previous version since we need to support step, while the previous version assumes.
   2. Kernel needs to take care of step as well.
   3. Kernel needs to copy shapes of data, out, and step in addition to the shapes of begin and end in the mshadow version.
   I can investigate to see which part takes this 10% more time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services