You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "jiangML (via GitHub)" <gi...@apache.org> on 2023/02/15 11:30:58 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #24180: add test for agent file and prometheus plugin
jiangML opened a new pull request, #24180:
URL: https://github.com/apache/shardingsphere/pull/24180
Fixes #24179.
Changes proposed in this pull request:
- add test for MetaDataContextsFactoryAdvice
- add IT test for prometheus
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin merged pull request #24180: add test for agent file and prometheus plugin
Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin merged PR #24180:
URL: https://github.com/apache/shardingsphere/pull/24180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24180: add test for agent file and prometheus plugin
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24180:
URL: https://github.com/apache/shardingsphere/pull/24180#issuecomment-1432514981
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24180](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d85ac1b) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b9f6a459e36fc002e6d10248aca4f28d29075443?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9f6a45) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d85ac1b differs from pull request most recent head 468c1bb. Consider uploading reports for the commit 468c1bb to get more accurate results
```diff
@@ Coverage Diff @@
## master #24180 +/- ##
============================================
+ Coverage 50.13% 50.14% +0.01%
Complexity 1579 1579
============================================
Files 3257 3257
Lines 53498 53495 -3
Branches 9855 9854 -1
============================================
+ Hits 26820 26826 +6
+ Misses 24321 24314 -7
+ Partials 2357 2355 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../metrics/core/exporter/impl/BuildInfoExporter.java](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9tZXRyaWNzL2NvcmUvZXhwb3J0ZXIvaW1wbC9CdWlsZEluZm9FeHBvcnRlci5qYXZh) | `100.00% <100.00%> (+9.09%)` | :arrow_up: |
| [...ogging/file/FileLoggingPluginLifecycleService.java](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL3R5cGUvZmlsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL2xvZ2dpbmcvZmlsZS9GaWxlTG9nZ2luZ1BsdWdpbkxpZmVjeWNsZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...authentication/OpenGaussAuthenticationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9mcm9udGVuZC9vcGVuZ2F1c3MvYXV0aGVudGljYXRpb24vT3BlbkdhdXNzQXV0aGVudGljYXRpb25IYW5kbGVyLmphdmE=) | `86.36% <0.00%> (+4.54%)` | :arrow_up: |
| [...ing/file/advice/MetaDataContextsFactoryAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/24180?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL3R5cGUvZmlsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvcGx1Z2luL2xvZ2dpbmcvZmlsZS9hZHZpY2UvTWV0YURhdGFDb250ZXh0c0ZhY3RvcnlBZHZpY2UuamF2YQ==) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org