You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/08/13 01:04:51 UTC
[kudu-CR] KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13721 )
Change subject: KUDU-2847: Optimize iteration over selection vector in SerializeRowBlock
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13721/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13721/7//COMMIT_MSG@10
PS7, Line 10: amortiznig
amortizing
http://gerrit.cloudera.org:8080/#/c/13721/7/src/kudu/common/rowblock.cc
File src/kudu/common/rowblock.cc:
http://gerrit.cloudera.org:8080/#/c/13721/7/src/kudu/common/rowblock.cc@91
PS7, Line 91: uint8_t bm = *bitmap++;
: while (bm != 0) {
: int bit = Bits::FindLSBSetNonZero(bm);
: *dst++ = (i * 8) + bit;
: bm ^= (1 << bit);
: }
nit: Jumping into this is can be intimidating with no comments. Maybe add a comment along the lines of:
Within each byte, keep flipping the least significant non-zero bit and adding the bit index to the output until none are set.
http://gerrit.cloudera.org:8080/#/c/13721/7/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:
http://gerrit.cloudera.org:8080/#/c/13721/7/src/kudu/common/wire_protocol.cc@927
PS7, Line 927: *slice = reinterpret_cast<const Slice *>(src);
: size_t offset_in_indirect = indirect_data->size();
: indirect_data->append(reinterpret_cast<const char*>(slice->data()), slice->size());
:
: Slice *
nit: fix ordering of *s
--
To view, visit http://gerrit.cloudera.org:8080/13721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19917d1875c46fd4cf98ef8a471b0340a76161e7
Gerrit-Change-Number: 13721
Gerrit-PatchSet: 7
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Tue, 13 Aug 2019 01:04:51 +0000
Gerrit-HasComments: Yes