[GitHub] [airflow] josh-fell opened a new pull request, #23373: Add doc notes for keyword-only args for `expand()` and `partial()`

[GitBox <gi...@apache.org>]

josh-fell opened a new pull request, #23373:
URL: https://github.com/apache/airflow/pull/23373

   While going through some exercises for Dynamic Task Mapping, I found myself wanting to pass positional arguments to `expand()` and getting met with valid `TypeError` exceptions for expecting only 1 positional argument when creating mapped tasks. Passing keyword-only arguments to `expand()` can be inferred from all of the great examples in the doc, but I thought it might be best to be explicit.  I also added a similar, explicit note for `partial()` as well.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23373: Add doc notes for keyword-only args for `expand()` and `partial()`

[GitBox <gi...@apache.org>]

github-actions[bot] commented on PR #23373:
URL: https://github.com/apache/airflow/pull/23373#issuecomment-1113915272

   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #23373: Add doc notes for keyword-only args for `expand()` and `partial()`

[GitBox <gi...@apache.org>]

eladkal commented on PR #23373:
URL: https://github.com/apache/airflow/pull/23373#issuecomment-1114025713

   Can we maybe change it from `TypeError` to something more informative thus users will understand the issue when encounter with it? I don't think documentation is the place to clarify such stuff. Can we say the "Only keyword arguments are allowed to be passed" in the exception rather than having a generic one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham merged pull request #23373: Add doc notes for keyword-only args for `expand()` and `partial()`

[GitBox <gi...@apache.org>]

jedcunningham merged PR #23373:
URL: https://github.com/apache/airflow/pull/23373


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org