You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/05/28 17:49:52 UTC

Review Request 34771: AMBARI-11488 Need to pass JAVA_HOME to credential helper script for KMS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34771/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew Onischuk, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: AMBARI-11488
    https://issues.apache.org/jira/browse/AMBARI-11488


Repository: ambari


Description
-------

Need to pass JAVA_HOME to credential helper script for KMS


Diffs
-----

  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 6fc8c99 

Diff: https://reviews.apache.org/r/34771/diff/


Testing
-------

Tested on local centos cluster with Ranger and Ranger KMS.

Ran 235 tests in 7.619s

OK
----------------------------------------------------------------------
Total run:744
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 34771: AMBARI-11488 Need to pass JAVA_HOME to credential helper script for KMS

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34771/#review85577
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On May 28, 2015, 3:49 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34771/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 3:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew Onischuk, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11488
>     https://issues.apache.org/jira/browse/AMBARI-11488
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to pass JAVA_HOME to credential helper script for KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 6fc8c99 
> 
> Diff: https://reviews.apache.org/r/34771/diff/
> 
> 
> Testing
> -------
> 
> Tested on local centos cluster with Ranger and Ranger KMS.
> 
> Ran 235 tests in 7.619s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


Re: Review Request 34771: AMBARI-11488 Need to pass JAVA_HOME to credential helper script for KMS

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34771/#review85579
-----------------------------------------------------------


We don't have unittests for this or why it don't?

- Andrew Onischuk


On May 28, 2015, 3:49 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34771/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 3:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew Onischuk, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-11488
>     https://issues.apache.org/jira/browse/AMBARI-11488
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to pass JAVA_HOME to credential helper script for KMS
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 6fc8c99 
> 
> Diff: https://reviews.apache.org/r/34771/diff/
> 
> 
> Testing
> -------
> 
> Tested on local centos cluster with Ranger and Ranger KMS.
> 
> Ran 235 tests in 7.619s
> 
> OK
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>