You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/09/12 13:42:15 UTC

[PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

pjfanning opened a new pull request, #2195:
URL: https://github.com/apache/pekko/pull/2195

   See https://github.com/apache/pekko-persistence-cassandra/issues/305 and #1940 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #2195: add back BackoffSupervisor.calculateDelay due to bin compat issues
URL: https://github.com/apache/pekko/pull/2195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2195:
URL: https://github.com/apache/pekko/pull/2195#issuecomment-3285508288

   > Seems like some internal api is been used across akka projects :(
   
   we can't assume package private code at [pekko] level is only used in this repo - it can be used in any of our repos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2195:
URL: https://github.com/apache/pekko/pull/2195#discussion_r2344432533


##########
actor/src/main/scala/org/apache/pekko/pattern/BackoffSupervisor.scala:
##########
@@ -311,6 +311,22 @@ object BackoffSupervisor {
    */
   @InternalApi
   private[pekko] case class ResetRestartCount(current: Int) extends DeadLetterSuppression
+
+  /**
+   * INTERNAL API
+   *
+   * Calculates an exponential back off delay.
+   *
+   * Was removed in 1.2.0 but added back in 1.2.1 for binary compatibility reasons.

Review Comment:
   I do - in the deprecation message below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #2195:
URL: https://github.com/apache/pekko/pull/2195#discussion_r2344392726


##########
actor/src/main/scala/org/apache/pekko/pattern/BackoffSupervisor.scala:
##########
@@ -311,6 +311,22 @@ object BackoffSupervisor {
    */
   @InternalApi
   private[pekko] case class ResetRestartCount(current: Int) extends DeadLetterSuppression
+
+  /**
+   * INTERNAL API
+   *
+   * Calculates an exponential back off delay.
+   *
+   * Was removed in 1.2.0 but added back in 1.2.1 for binary compatibility reasons.

Review Comment:
   We should point to the new methods in 2.0.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #2195:
URL: https://github.com/apache/pekko/pull/2195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #2195:
URL: https://github.com/apache/pekko/pull/2195#issuecomment-3285500186

   Seems like some internal api is been used across akka projects :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] add back BackoffSupervisor.calculateDelay due to bin compat issues [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #2195:
URL: https://github.com/apache/pekko/pull/2195#issuecomment-3285784146

   seems like we will do a release soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org