You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/09/07 08:00:29 UTC
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-test
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7991
to review the following change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-test
......................................................................
Rename tombstoned_voting-itest to tombstoned_voting-test
tombstoned_voting-itest uses an InternalMiniCluster, and it would be
useful to have tombstoned voting tests that use an ExternalMiniCluster.
Rename the existing IMC-based test to -test prefix to make room for an
EMC-based test that has an -itest prefix.
Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/tombstoned_voting-test.cc
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/7991/1
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-imc-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
......................................................................
Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
tombstoned_voting-itest uses an InternalMiniCluster, and it would be
useful to have tombstoned voting tests that use an ExternalMiniCluster.
Rename the existing IMC-based test to make room for an EMC-based test.
Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Reviewed-on: http://gerrit.cloudera.org:8080/7991
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-imc-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7991
to look at the new patch set (#2).
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
......................................................................
Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
tombstoned_voting-itest uses an InternalMiniCluster, and it would be
useful to have tombstoned voting tests that use an ExternalMiniCluster.
Rename the existing IMC-based test to make room for an EMC-based test.
Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
---
M src/kudu/integration-tests/CMakeLists.txt
R src/kudu/integration-tests/tombstoned_voting-imc-itest.cc
2 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/7991/2
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-test
......................................................................
Patch Set 1:
(2 comments)
I though the '-itest' suffix stood for 'integration test'.
Maybe, rename the file to reflect the usage of the IMC via adding that into the suffix instead? E.g.,
tombstoned_voting-itest.cc --> tombstoned_voting-imc-itest.cc ?
http://gerrit.cloudera.org:8080/#/c/7991/1//COMMIT_MSG
Commit Message:
PS1, Line 11: prefix
suffix?
PS1, Line 12: prefix
suffix?
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-test
......................................................................
Patch Set 1:
(2 comments)
> tombstoned_voting-itest.cc --> tombstoned_voting-imc-itest.cc ?
Done
http://gerrit.cloudera.org:8080/#/c/7991/1//COMMIT_MSG
Commit Message:
PS1, Line 11: prefix
> suffix?
Done
PS1, Line 12: prefix
> suffix?
Done
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Rename tombstoned voting-itest to tombstoned voting-imc-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Rename tombstoned_voting-itest to tombstoned_voting-imc-itest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9fd979ca1bb61450a7b54d7b85920674aefd06
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No