You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by chirino <gi...@git.apache.org> on 2016/03/30 22:50:23 UTC

[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

GitHub user chirino opened a pull request:

    https://github.com/apache/qpid-jms/pull/2

    Implements QPIDJMS-164 - Provide an OSGi bundle for the Qpid JMS client

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chirino/qpid-jms master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-jms/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the pull request:

    https://github.com/apache/qpid-jms/pull/2#issuecomment-203999771
  
    I rather dislike the uber bundle approach. Tim already did a little groundwork previously on updating our various dependencies to ensure they do/will provide osgi metadata, I think I'd rather see that work taken forward than to add a separate osgi uber module if at all avoidable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the pull request:

    https://github.com/apache/qpid-jms/pull/2#issuecomment-204055703
  
    I did add the BND plugin to proton-j recently in order to generate bundle information in the next release, a review from someone more versed in OSGi would be good.  
    
    The client would work with any Netty version in the 4.0.x series given our past testing.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-jms pull request #2: Implements QPIDJMS-164 - Provide an OSGi bundle fo...

Posted by chirino <gi...@git.apache.org>.
Github user chirino closed the pull request at:

    https://github.com/apache/qpid-jms/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-jms pull request: Implements QPIDJMS-164 - Provide an OSGi bu...

Posted by chirino <gi...@git.apache.org>.
Github user chirino commented on the pull request:

    https://github.com/apache/qpid-jms/pull/2#issuecomment-204042552
  
    So some of the issues then you have to take on is make sure your internal dependencies work well add mixed versions.  For example will your lib work well with the Netty versions that are shipped with Fuse?  Have you guys made a proper OSGi bundle for proton-j?
    
    This uber bundle just ubers protonj and netty since they are internal implementation details.  It imports the logging and and JMS libs since they need to be shared.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org