You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2017/01/09 19:46:35 UTC
Review Request 55353: Fix for ATLAS-1434.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1434
https://issues.apache.org/jira/browse/ATLAS-1434
Repository: atlas
Description
-------
Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages to indicate the operation in which the validation failure was encountered.
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java edd12ab
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 4b500ff
Diff: https://reviews.apache.org/r/55353/diff/
Testing
-------
- Executed unit tests.
Thanks,
Ashutosh Mestry
Re: Review Request 55353: Fix for ATLAS-1434.
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/#review161328
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 92)
<https://reviews.apache.org/r/55353/#comment232568>
Update/Create can be determined from the isUpdate boolean in createOrUpdateTypes signature. Is this enum needed ?
- Apoorv Naik
On Jan. 9, 2017, 7:46 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55353/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 7:46 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1434
> https://issues.apache.org/jira/browse/ATLAS-1434
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages to indicate the operation in which the validation failure was encountered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java edd12ab
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 4b500ff
>
> Diff: https://reviews.apache.org/r/55353/diff/
>
>
> Testing
> -------
>
> - Executed unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 55353: Fix for ATLAS-1434.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/#review161183
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 60)
<https://reviews.apache.org/r/55353/#comment232419>
"a-zA-z" ==> "a-zA-Z"
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 62)
<https://reviews.apache.org/r/55353/#comment232420>
In the current version "Triat" is replaced with "Classification". I would suggest to use "Classification"
- Madhan Neethiraj
On Jan. 9, 2017, 7:46 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55353/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 7:46 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1434
> https://issues.apache.org/jira/browse/ATLAS-1434
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages to indicate the operation in which the validation failure was encountered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java edd12ab
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 4b500ff
>
> Diff: https://reviews.apache.org/r/55353/diff/
>
>
> Testing
> -------
>
> - Executed unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 55353: Fix for ATLAS-1434.
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/#review161354
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 64)
<https://reviews.apache.org/r/55353/#comment232598>
Please change the message to "Only Alphabets, numbers and '_' are allowed.
"Characters" includes everything!
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java (line 1148)
<https://reviews.apache.org/r/55353/#comment232597>
Please add a test for the case where a trait with "." in name is created successfully
- Vimal Sharma
On Jan. 9, 2017, 7:46 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55353/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 7:46 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1434
> https://issues.apache.org/jira/browse/ATLAS-1434
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages to indicate the operation in which the validation failure was encountered.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java edd12ab
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 4b500ff
>
> Diff: https://reviews.apache.org/r/55353/diff/
>
>
> Testing
> -------
>
> - Executed unit tests.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>