[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616821#comment-16616821 ] 

ASF GitHub Bot commented on CB-11714:
-------------------------------------

janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width
URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-421804440
 
 
   Hey @DisruptiveMind , there seems to be a merge conflict now. Could you maybe fix this? Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Camera plugin for windows does not properly set content-type when selecting JPG->PNG
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11714
>                 URL: https://issues.apache.org/jira/browse/CB-11714
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>    Affects Versions: Master
>         Environment: Windows 10
>            Reporter: Tyler Pham
>            Priority: Major
>              Labels: easyfix, triaged, windows
>
> When selecting a JPG with encodingType = Camera.EncodingType.PNG, the resizeImage() will not modify the target content type when converting canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a .png extension which will cause the browser to not render to image and issue an error.
> Possibly related to: CB-8618
> I have created a small fix at:
> https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org