You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by chuanlei <gi...@git.apache.org> on 2015/06/01 17:45:16 UTC
[GitHub] storm pull request: fix the dismatch between doc and code for read...
GitHub user chuanlei opened a pull request:
https://github.com/apache/storm/pull/570
fix the dismatch between doc and code for read-all-supervisor-details
fix the dismatch between doc and source code in function read-all-supervisor-details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chuanlei/storm fix-documentation-for-function-read-all-supervisor-details
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #570
----
commit 77164e0365c198e9ec090634a138bf46858dbc30
Author: chuanlei <ni...@126.com>
Date: 2015-06-01T15:38:38Z
fix the dismatch between doc and source code in function read-all-supervisor-details
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122277257
@chuanlei Thanks, it's my pleasure. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-109562149
I think you need to read https://github.com/apache/storm/blob/master/DEVELOPER.md to get familiar with contributing to Apache Storm Project.
You may want to read http://storm.apache.org/documentation/BYLAWS.html, too.
Btw, looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] storm pull request: fix the dismatch between doc and
code for read...
Posted by 倪传蕾 <ni...@gmail.com>.
Hi,
I am a newbie to the open source community. And I just modify the
doc-string for the function read-all-supervisor-details and propose a pr.
Now the CI failed. Anyone can tell me the reason and how can I fix it?
Thanks.
2015-06-01 23:45 GMT+08:00 chuanlei <gi...@git.apache.org>:
> GitHub user chuanlei opened a pull request:
>
> https://github.com/apache/storm/pull/570
>
> fix the dismatch between doc and code for read-all-supervisor-details
>
> fix the dismatch between doc and source code in function
> read-all-supervisor-details
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/chuanlei/storm
> fix-documentation-for-function-read-all-supervisor-details
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/storm/pull/570.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #570
>
> ----
> commit 77164e0365c198e9ec090634a138bf46858dbc30
> Author: chuanlei <ni...@126.com>
> Date: 2015-06-01T15:38:38Z
>
> fix the dismatch between doc and source code in function
> read-all-supervisor-details
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122084941
@HeartSaVioR Sounds good. Thanks by the way for all of the reviews before becoming a committer. We need more people to keep up with all of the pull requests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122113786
@revans2
Sure. The more, the better.
We(PMC members) are responsible for considering how to make Storm community more active.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-107730861
You don't need to worry about test failures. It's random test failure which Storm struggles with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by chuanlei <gi...@git.apache.org>.
Github user chuanlei commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122240118
@revans2 @HeartSaVioR
Thank you very much. @HeartSaVioR has helped me a lot in the Storm topic. You can really patient and friendly to newbie to Storm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by chuanlei <gi...@git.apache.org>.
Github user chuanlei commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-108922882
what should I do so that this pr can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122071976
@chuanlei Sorry this has taken so long. The change looks good to me. +1
@HeartSaVioR I don't think we need a JIRA for this, it is a minor documentation change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/570#issuecomment-122078266
@revans2
I didn't mean this PR needs a JIRA issue. I just guided @chuanlei to get familiar with contributing rule while waiting for committers to review.
I wasn't a committer at that time, so I couldn't give +1. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix the dismatch between doc and code for read...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---