You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/17 23:20:56 UTC

Review Request: Test suite test_shared_networks.py not executing since missing import attr

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11917/
-----------------------------------------------------------

Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
-------

Test suite test_shared_networks.py not executing since missing import attr

added 

from nose.plugins.attrib import attr


Diffs
-----


Diff: https://reviews.apache.org/r/11917/diff/


Testing
-------


Thanks,

Rayees Namathponnan


Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11917/#review22042
-----------------------------------------------------------


You forgot the diff (again)

- Prasanna Santhanam


On June 17, 2013, 9:21 p.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11917/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 9:21 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Test suite test_shared_networks.py not executing since missing import attr
> 
> added 
> 
> from nose.plugins.attrib import attr
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11917/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11917/#review22049
-----------------------------------------------------------

Ship it!


76520e8

- Prasanna Santhanam


On June 18, 2013, 6:07 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11917/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 6:07 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Test suite test_shared_networks.py not executing since missing import attr
> 
> added 
> 
> from nose.plugins.attrib import attr
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/11917/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>


Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr

Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11917/
-----------------------------------------------------------

(Updated June 18, 2013, 6:07 a.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Changes
-------

Attached Patch


Description
-------

Test suite test_shared_networks.py not executing since missing import attr

added 

from nose.plugins.attrib import attr


Diffs
-----


Diff: https://reviews.apache.org/r/11917/diff/


Testing
-------

Tested 


Thanks,

Rayees Namathponnan


Re: Review Request: Test suite test_shared_networks.py not executing since missing import attr

Posted by Rayees Namathponnan <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11917/
-----------------------------------------------------------

(Updated June 17, 2013, 9:21 p.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
-------

Test suite test_shared_networks.py not executing since missing import attr

added 

from nose.plugins.attrib import attr


Diffs
-----


Diff: https://reviews.apache.org/r/11917/diff/


Testing (updated)
-------

Tested 


Thanks,

Rayees Namathponnan