[jira] [Commented] (FLINK-9696) Deep toString for arrays/map in SQL client

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529096#comment-16529096 ] 

ASF GitHub Bot commented on FLINK-9696:
---------------------------------------

Github user hequn8128 commented on the issue:

    https://github.com/apache/flink/pull/6233
  
    Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function returns result correctly. I could not spot any issues with the implementation. To make the PR better, I think we can add a test in `CliUtilsTest` to test the `rowToString` function, since code in the function also has been changed. BTW, the PR template can be done better. See for PR https://github.com/apache/flink/pull/5811 as an example.
    Best, Hequn


> Deep toString for arrays/map in SQL client 
> -------------------------------------------
>
>                 Key: FLINK-9696
>                 URL: https://issues.apache.org/jira/browse/FLINK-9696
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> Currently SQL client does not show arrays/map in human readable way (please have a look at examples below). e.g. {code}select map[1,2];{code} is shown as {noformat} +/-                    EXPR$0
>    +         java.util.HashMap
> {noformat}
> {code}select array[1,2];{code} is shown as {noformat}
> +/-                    EXPR$0
>    +       java.lang.Integer[]
> {noformat} 
> {code}select array[map[1,2],map[2,2]];{code} is shown as {noformat} +/-                    EXPR$0
>    +           java.util.Map[]{noformat}
> {code}select map[array[1,2], array[1,2]];{code} is shown as {noformat} +/-                    EXPR$0
>    +         java.util.HashMap{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)