You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Teemu Koponen (JIRA)" <ji...@apache.org> on 2010/02/16 05:10:28 UTC
[jira] Created: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
-------------------------------------------------------------------------------------------------------------------------------------
Key: THRIFT-705
URL: https://issues.apache.org/jira/browse/THRIFT-705
Project: Thrift
Issue Type: Bug
Components: Library (C++)
Environment: Any Thrift compatible C++ compiler environment.
Reporter: Teemu Koponen
The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
http://sources.redhat.com/autobook/autobook/autobook_96.html
Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905538#action_12905538 ]
David Reiss commented on THRIFT-705:
------------------------------------
Sure. I'd like to compare the two approaches.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-705) Installed C++ header
files depend on "config.h" which may have conflicting macros with the
(autoconf based) C++ project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905854#action_12905854 ]
Ivan Murashko edited comment on THRIFT-705 at 9/3/10 7:24 AM:
--------------------------------------------------------------
The patch (config_h_patch-r991496.diff) removes all references about config.h file from headers and put them into beginning of each cpp file.
was (Author: ivanm):
The patch (config_h_patch-r991496.diff) removes all reverences about config.h file from headers and put them into beginning of each cpp file.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Teemu Koponen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Teemu Koponen updated THRIFT-705:
---------------------------------
Attachment: config-h-patch.diff
A patch against the latest git master.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: Library (C++)
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-705) Installed C++ header
files depend on "config.h" which may have conflicting macros with the
(autoconf based) C++ project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905854#action_12905854 ]
Ivan Murashko edited comment on THRIFT-705 at 9/3/10 7:23 AM:
--------------------------------------------------------------
The patch (config_h_patch-r991496.diff) removes all reverences about config.h file from headers and put them into beginning of each cpp file.
was (Author: ivanm):
The patch removes all reverences about config.h file from headers and put them into beginning of each cpp file.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Mina Naguib (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907189#action_12907189 ]
Mina Naguib commented on THRIFT-705:
------------------------------------
By the way, this issue, indirectly, causes breakage when using thrift to generate code for the cassandra interface file.
It just so happens that the cassandra.thrift file declares:
const string VERSION = "2.2.0"
When thrift cpp code is generated, the cassandra_constants.h file contains:
std::string VERSION;
However, if the program that includes that file uses autotools, that file will get compiled with -DHAVE_CONFIG. This will trickle down to the thrift headers themselves, which will then import thrift's own config.h, which has this:
#define VERSION "0.4.0"
And so, VERSION is substituted back in cassandra_constants.h, making the post-preprocessor output:
std::string "0.4.0";
Which is a syntax error, and will not compile.
I actually ran into this issue maintaining libcassandra (a C++/C client API) and had to manually tweak the generated CPP code to make it compile.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-705) Installed C++ header
files depend on "config.h" which may have conflicting macros with the
(autoconf based) C++ project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905854#action_12905854 ]
Ivan Murashko edited comment on THRIFT-705 at 9/9/10 4:19 AM:
--------------------------------------------------------------
The patch (config_h_patch-r994950.diff) removes all references about config.h file from headers and put them into beginning of each cpp file.
was (Author: ivanm):
The patch (config_h_patch-r991496.diff) removes all references about config.h file from headers and put them into beginning of each cpp file.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r994950.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Murashko updated THRIFT-705:
---------------------------------
Attachment: config_h_patch-r994950.diff
I've updated my patch. The config.h is not installed to include folder. The config.h is included into tests cpps
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r994950.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-705) Installed C++ header
files depend on "config.h" which may have conflicting macros with the
(autoconf based) C++ project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905854#action_12905854 ]
Ivan Murashko edited comment on THRIFT-705 at 9/3/10 7:23 AM:
--------------------------------------------------------------
The patch removes all reverences about config.h file from headers and put them into beginning of each cpp file.
was (Author: ivanm):
The patch removed all reverences about config.h file from headers and put them into beginning of each cpp file.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905947#action_12905947 ]
David Reiss commented on THRIFT-705:
------------------------------------
I'm surprised that there are so few headers that require config parameters, but there are still some. For example, I think this breaks the HAVE_INTTYPES check in Thrift.h.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905512#action_12905512 ]
Ivan Murashko commented on THRIFT-705:
--------------------------------------
I also have the same problem when trying to use the thrift with my autoconf based solution. I resolved it by removing references to config.h from all header files and put them into each cpp ones. May be there is a more better solution because the content of the config.h file is for internal usage and should not be published in the interface.
BTW: I can put the patch if somebody is interested in it
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Murashko updated THRIFT-705:
---------------------------------
Attachment: config_h_patch-r991496.diff
The patch removed all reverences about config.h file from headers and put them into beginning of each cpp file.
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Murashko updated THRIFT-705:
---------------------------------
Attachment: (was: config_h_patch-r991496.diff)
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r994950.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-705) Installed C++ header files depend on
"config.h" which may have conflicting macros with the (autoconf based) C++
project using Thrift.
Posted by "Ivan Murashko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906027#action_12906027 ]
Ivan Murashko commented on THRIFT-705:
--------------------------------------
It has not to break HAVE_INTTYPES. The define will be recognized in a cpp file because each cpp have config.h include before any others.
BTW: Typical usage of the header is in fprintf like expressions. I run a simple grep and could not find any real usage of the header. Could you correct me if I am wrong
> Installed C++ header files depend on "config.h" which may have conflicting macros with the (autoconf based) C++ project using Thrift.
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-705
> URL: https://issues.apache.org/jira/browse/THRIFT-705
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Environment: Any Thrift compatible C++ compiler environment.
> Reporter: Teemu Koponen
> Attachments: config-h-patch.diff, config_h_patch-r991496.diff
>
>
> The public, installed Thrift C++ header files depend on an autoconf generated system specific 'config.h' header file. Unfortunately, having this header file as a part of the library headers is generally troublesome. For example, see:
> http://sources.redhat.com/autobook/autobook/autobook_96.html
> Attached is a patch that relies on an alternative, simpler approach based on AX_PREFIX_CONFIG_H, which adds a package prefix to both config.h file name and to the macros defined within:
> http://www.nongnu.org/autoconf-archive/ax_prefix_config_h.html
> The resulting thrift-config.h can be installed and included safely from C++ applications having their own config.h.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.