[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1798: mmcsd: Allow setting ID Mode SPI frequency vi Kconfig

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #1798:
URL: https://github.com/apache/incubator-nuttx/pull/1798#discussion_r489099771



##########
File path: drivers/mmcsd/mmcsd_spi.c
##########
@@ -61,7 +61,9 @@
 #  define CONFIG_MMCSD_NSLOTS 1
 #endif
 
-#define MMCSD_IDMODE_CLOCK           (400000)
+#ifndef CONFIG_MMCSD_IDMODE_CLOCK
+#  define CONFIG_MMCSD_IDMODE_CLOCK 400000
+#endif

Review comment:
       > 
   > 
   > This is a pattern I see in a lot of places, for example right above with `CONFIG_MMCSD_NSLOTS` so I keeping it. Should I remove that as well?
   
   It is a holdover from the days before kconfig-frontends when .config files were edited by hand.  In that case, extensive verification of configuration settings was needed at compile time.  But it is probably no longer necessary; we depend on the Kconfigs to assure that everything is defined and valid.
   
   There is a lot of old stuff in config.h generated in mkconfig.c that could be removed too.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org