You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2014/02/24 07:58:39 UTC

[1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Repository: flex-sdk
Updated Branches:
  refs/heads/develop 4e0fba518 -> 1cfe16837


Now able to compile on 10.2 and 10.3 which doesn't have JSON support


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/daed2dfd
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/daed2dfd
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/daed2dfd

Branch: refs/heads/develop
Commit: daed2dfd37da70af303883d34780018e06b80b56
Parents: 4e0fba5
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Feb 24 17:57:45 2014 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Feb 24 17:57:45 2014 +1100

----------------------------------------------------------------------
 .../projects/framework/src/mx/collections/ArrayCollection.as       | 2 +-
 frameworks/projects/framework/src/mx/collections/ArrayList.as      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
index 9d6f18d..589cc41 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
@@ -158,7 +158,7 @@ public class ArrayCollection extends ListCollectionView implements IExternalizab
 	public function toJSON(s:String):*
 	{
 		var array:Array = toArray();
-		return JSON.stringify(array);
+		return this["JSON"].stringify(array);
 	}
 	
     /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayList.as b/frameworks/projects/framework/src/mx/collections/ArrayList.as
index abdb09b..117793a 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayList.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayList.as
@@ -282,7 +282,7 @@ public class ArrayList extends EventDispatcher
 	public function toJSON(s:String):*
 	{
 		var array:Array = toArray();
-		return JSON.stringify(array);
+		return this["JSON"].stringify(array);
 	}
 	
     /**


Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> Wow, didn't know you could do this["JSON"] to access a top-level class.  
Well it compiles but doesn't work so scrap that idea.

> I think other places in the SDK use ApplicationDomain.hasDefinition/getDefinition.
Guess I have to use that.

Thanks,
Justin

RE: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Posted by Alex Harui <ah...@adobe.com>.
Wow, didn't know you could do this["JSON"] to access a top-level class.  I guess that works because of lexical scoping?

I think other places in the SDK use ApplicationDomain.hasDefinition/getDefinition.

-Alex
________________________________________
From: jmclean@apache.org [jmclean@apache.org]
Sent: Sunday, February 23, 2014 10:58 PM
To: commits@flex.apache.org
Subject: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Repository: flex-sdk
Updated Branches:
  refs/heads/develop 4e0fba518 -> 1cfe16837


Now able to compile on 10.2 and 10.3 which doesn't have JSON support


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/daed2dfd
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/daed2dfd
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/daed2dfd

Branch: refs/heads/develop
Commit: daed2dfd37da70af303883d34780018e06b80b56
Parents: 4e0fba5
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Feb 24 17:57:45 2014 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Feb 24 17:57:45 2014 +1100

----------------------------------------------------------------------
 .../projects/framework/src/mx/collections/ArrayCollection.as       | 2 +-
 frameworks/projects/framework/src/mx/collections/ArrayList.as      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
index 9d6f18d..589cc41 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
@@ -158,7 +158,7 @@ public class ArrayCollection extends ListCollectionView implements IExternalizab
        public function toJSON(s:String):*
        {
                var array:Array = toArray();
-               return JSON.stringify(array);
+               return this["JSON"].stringify(array);
        }

     /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayList.as b/frameworks/projects/framework/src/mx/collections/ArrayList.as
index abdb09b..117793a 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayList.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayList.as
@@ -282,7 +282,7 @@ public class ArrayList extends EventDispatcher
        public function toJSON(s:String):*
        {
                var array:Array = toArray();
-               return JSON.stringify(array);
+               return this["JSON"].stringify(array);
        }

     /**

RE: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Posted by Alex Harui <ah...@adobe.com>.
Wow, didn't know you could do this["JSON"] to access a top-level class.  I guess that works because of lexical scoping?

I think other places in the SDK use ApplicationDomain.hasDefinition/getDefinition.

-Alex
________________________________________
From: jmclean@apache.org [jmclean@apache.org]
Sent: Sunday, February 23, 2014 10:58 PM
To: commits@flex.apache.org
Subject: [1/2] git commit: [flex-sdk] [refs/heads/develop] - Now able to compile on 10.2 and 10.3 which doesn't have JSON support

Repository: flex-sdk
Updated Branches:
  refs/heads/develop 4e0fba518 -> 1cfe16837


Now able to compile on 10.2 and 10.3 which doesn't have JSON support


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/daed2dfd
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/daed2dfd
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/daed2dfd

Branch: refs/heads/develop
Commit: daed2dfd37da70af303883d34780018e06b80b56
Parents: 4e0fba5
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Feb 24 17:57:45 2014 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Feb 24 17:57:45 2014 +1100

----------------------------------------------------------------------
 .../projects/framework/src/mx/collections/ArrayCollection.as       | 2 +-
 frameworks/projects/framework/src/mx/collections/ArrayList.as      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
index 9d6f18d..589cc41 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayCollection.as
@@ -158,7 +158,7 @@ public class ArrayCollection extends ListCollectionView implements IExternalizab
        public function toJSON(s:String):*
        {
                var array:Array = toArray();
-               return JSON.stringify(array);
+               return this["JSON"].stringify(array);
        }

     /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/daed2dfd/frameworks/projects/framework/src/mx/collections/ArrayList.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/ArrayList.as b/frameworks/projects/framework/src/mx/collections/ArrayList.as
index abdb09b..117793a 100644
--- a/frameworks/projects/framework/src/mx/collections/ArrayList.as
+++ b/frameworks/projects/framework/src/mx/collections/ArrayList.as
@@ -282,7 +282,7 @@ public class ArrayList extends EventDispatcher
        public function toJSON(s:String):*
        {
                var array:Array = toArray();
-               return JSON.stringify(array);
+               return this["JSON"].stringify(array);
        }

     /**

[2/2] git commit: [flex-sdk] [refs/heads/develop] - update release notes

Posted by jm...@apache.org.
update release notes


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/1cfe1683
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/1cfe1683
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/1cfe1683

Branch: refs/heads/develop
Commit: 1cfe1683749033bfa8c514634fdb41adecb7c0ff
Parents: daed2df
Author: Justin Mclean <jm...@apache.org>
Authored: Mon Feb 24 17:58:26 2014 +1100
Committer: Justin Mclean <jm...@apache.org>
Committed: Mon Feb 24 17:58:26 2014 +1100

----------------------------------------------------------------------
 RELEASE_NOTES | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/1cfe1683/RELEASE_NOTES
----------------------------------------------------------------------
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index 270ddee..3cbf38d 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -145,6 +145,7 @@ FLEX-33715  Error: Attempted access of inaccessible method getStyle through a re
 FLEX-33671  Warning messages when using experimental components.
 FLEX-33632  Getting Run Time Error when loading resource module at runtime.
 FLEX-26768  When debugging multi-module projects impossible to set breakpoint
+FLEX-26308  ListCollectionView addAllAt causes RTE on filtered collections
 FLEX-25962  PopupAnchor needs modal functionality
 FLEX-24623  Remove private declarations in PopUpAnchor