[PR] KAFKA-19768: test on 4.3 [kafka]

["cychiu8 (via GitHub)" <gi...@apache.org>]

cychiu8 opened a new pull request, #22061:
URL: https://github.com/apache/kafka/pull/22061

   Summary: test the https://github.com/apache/kafka/pull/20805 on 4.3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19768: test on 4.3 [kafka]

["cychiu8 (via GitHub)" <gi...@apache.org>]

cychiu8 closed pull request #22061: KAFKA-19768: test on 4.3
URL: https://github.com/apache/kafka/pull/22061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-19768: test on 4.3 [kafka]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #22061:
URL: https://github.com/apache/kafka/pull/22061#discussion_r3083398697


##########
.github/workflows/ci-complete.yml:
##########
@@ -32,30 +32,54 @@ run-name: Build Scans for ${{ github.event.workflow_run.display_title}}
 # the repository secrets. Here we can download the build scan files produced by a PR and publish
 # them to develocity.apache.org.
 #
+# The CI workflow itself runs according to the branch of the PR or push event. However, this
+# ci-complete workflow always runs using the trunk branch, regardless of the source branch of the
+# CI workflow.
+#
 # If we need to do things like comment on, label, or otherwise modify PRs from public forks. This
 # workflow is the place to do it. PR number is ${{ github.event.workflow_run.pull_requests[0].number }}
 
 jobs:
+  get-build-scan-names:
+    if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure')
+    runs-on: ubuntu-latest
+    outputs:
+      build-scan-names: ${{ steps.build-scan-names.outputs.build-scan-names }}
+    steps:
+      - name: List buildscan artifacts
+        id: build-scan-names
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          RUN_ID: ${{ github.event.workflow_run.id }}
+        run: |
+          names=$(gh api \
+            -H "Accept: application/vnd.github+json" \
+            /repos/${{ github.repository }}/actions/runs/$RUN_ID/artifacts \
+            --jq '[.artifacts[] | select(.name | startswith("build-scan-")) | .name]')
+          echo "Found: $names"
+
+          echo "build-scan-names=$names" >> $GITHUB_OUTPUT
+
   upload-build-scan:
+    needs: get-build-scan-names
     # Skip this workflow if the CI run was skipped or cancelled
     if: (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure')
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        # Make sure these match build.yml and also keep in mind that GitHub Actions build will always use this file from the trunk branch.
-        java: [ 25, 17 ]
-        run-flaky: [ true, false ]
-        run-new: [ true, false ]
-        exclude:
-          - run-flaky: true
-            run-new: true
-
-    env:
-      job-variation: ${{ matrix.java }}-${{ matrix.run-flaky == true && 'flaky' || 'noflaky' }}-${{ matrix.run-new == true && 'new' || 'nonew' }}
-      status-context: Java ${{ matrix.java }}${{ matrix.run-flaky == true && ' / Flaky' || '' }}${{ matrix.run-new == true && ' / New' || '' }}
-
+        build-scan-name: ${{ fromJson(needs.get-build-scan-names.outputs.build-scan-names) }}
     steps:
+      - name: Setup build scan info
+        run: |
+          BUILD_SCAN_NAME="${{ matrix.build-scan-name }}"
+          JAVA=$(echo "$BUILD_SCAN_NAME" | grep -oE '[0-9]+')
+          STATUS_CONTEXT="Java $JAVA"
+          [[ "$BUILD_SCAN_NAME" == *"-flaky"* ]] && STATUS_CONTEXT="$STATUS_CONTEXT / Flaky"
+          [[ "$BUILD_SCAN_NAME" == *"-new"* ]] && STATUS_CONTEXT="$STATUS_CONTEXT / New"

Review Comment:
   `STATUS_CONTEXT` is derived only from the extracted Java version (plus optional `-flaky`/`-new` flags). If the CI run produces multiple build-scan artifacts for the same Java version that don’t include those suffixes (e.g. `build-scan-test-17` and `build-scan-quarantined-test-17`), the commit status `context` will collide and later updates will overwrite earlier ones. Consider including a unique identifier (for example the full `matrix.build-scan-name` or the artifact name minus the `build-scan-` prefix) in `STATUS_CONTEXT` so each scan publishes to a distinct status check.
   ```suggestion
             SCAN_ID="${BUILD_SCAN_NAME#build-scan-}"
             JAVA=$(echo "$BUILD_SCAN_NAME" | grep -oE '[0-9]+')
             STATUS_CONTEXT="Java $JAVA / $SCAN_ID"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org