You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/01 15:34:40 UTC

[GitHub] sijie commented on a change in pull request #2684: [function] Fix expected health check interval

sijie commented on a change in pull request #2684: [function] Fix expected health check interval
URL: https://github.com/apache/pulsar/pull/2684#discussion_r221655120
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
 ##########
 @@ -69,7 +69,7 @@ public void start() throws Exception {
                 details.getName(), this.instanceConfig.getInstanceId());
 
         runtime = runtimeFactory.createContainer(this.instanceConfig, codeFile,
-                instanceLivenessCheckFreqMs * 1000);
+                instanceLivenessCheckFreqMs / 1000);
 
 Review comment:
   I don't understand your comment here. "instanceLivenessCheckFreqMs" is in milliseconds, and have "ms" at the end is clear. Here we divide it by 1000 to convert it to seconds. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services