[GitHub] [ozone] rakeshadr edited a comment on pull request #2533: HDDS-5370. [FSO] Handle OMClientRequest based on the bucket layout.

[GitBox <gi...@apache.org>]

rakeshadr edited a comment on pull request #2533:
URL: https://github.com/apache/ozone/pull/2533#issuecomment-899209334


   @aryangupta1998 There are test case failures, due to the refactored logic of isBucketFSOptimized. Please skip the `isBucketFSOptimized` check by setting the flag to `isFSOBucketCheckEnabled` false.
   
   On a second thought, like we discussed offline we can add a safer null check for the `ozoneManager == null` instead of using the above mentioned flag. ozoneManager can be null for non-FSO test cases and will execute non-FSO code path. 
   But, please ensure that all `*FSO test cases` would see a non-null ozoneManager to cover the FSO execution code path.
   
   https://github.com/apache/ozone/pull/2533/files#diff-bde0dade7dd5ddda419499f4f999d25d40fcec1412e0ce809c36ffd1be473f22R3101
   
   
     ```
   public boolean isBucketFSOptimized(String volName, String buckName)
         throws IOException {
       // safer check for unit test case. In reality ozoneManager will never be null
       if (ozoneManager == null) {
         return false;
       } 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org