You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/29 12:34:00 UTC

[jira] [Commented] (AIRFLOW-5769) Move the S3_hook to /providers/aws/hooks

    [ https://issues.apache.org/jira/browse/AIRFLOW-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961961#comment-16961961 ] 

ASF GitHub Bot commented on AIRFLOW-5769:
-----------------------------------------

mik-laj commented on pull request #6443: [AIRFLOW-5769] Move the S3_hook to /providers/aws/hooks
URL: https://github.com/apache/airflow/pull/6443
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Move the S3_hook to /providers/aws/hooks
> ----------------------------------------
>
>                 Key: AIRFLOW-5769
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5769
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 2.0.0
>            Reporter: MinJae Kwon
>            Assignee: MinJae Kwon
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> All S3 related python files are using the "s3_" prefix, except only "S3_hook.py".
> It should be renamed to "s3_hook.py" (and also all import statements in dependant codes) for keeping naming consistency I think.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)